Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pool to be destroyed with an extra (erroneous) consumer reference on the pool account #4503

Merged
merged 3 commits into from
May 17, 2024

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented May 17, 2024

addresses #4440 (will close once we have this in prod runtimes).
related: #2037.

An extra consumer reference is preventing pools to be destroyed. When a pool is ready to be destroyed, we
can safely clear the consumer references if any. Notably, I only check for one extra consumer reference since that is a known bug. Anything more indicates possibly another issue and we probably don't want to silently absorb those errors as well.

After this change, pools with extra consumer reference should be able to destroy normally.

@Ank4n Ank4n added the I2-bug The node fails to follow expected behavior. label May 17, 2024
@Ank4n Ank4n added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 2e36f57 May 17, 2024
151 of 152 checks passed
@Ank4n Ank4n deleted the ankan/destroy-pool branch May 17, 2024 12:32
Ank4n added a commit that referenced this pull request May 20, 2024
…ce on the pool account (#4503)

addresses #4440 (will
close once we have this in prod runtimes).
related: #2037.

An extra consumer reference is preventing pools to be destroyed. When a
pool is ready to be destroyed, we
can safely clear the consumer references if any. Notably, I only check
for one extra consumer reference since that is a known bug. Anything
more indicates possibly another issue and we probably don't want to
silently absorb those errors as well.

After this change, pools with extra consumer reference should be able to
destroy normally.
Ank4n added a commit that referenced this pull request May 20, 2024
…ef to be destroyed. (#4524)

Backporting #4503 to
polkadot-sdk 1.7.0 release. Should bump `pallet-nomination-pools` from
`26.0.0` to `26.0.1`.
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…ce on the pool account (paritytech#4503)

addresses paritytech#4440 (will
close once we have this in prod runtimes).
related: paritytech#2037.

An extra consumer reference is preventing pools to be destroyed. When a
pool is ready to be destroyed, we
can safely clear the consumer references if any. Notably, I only check
for one extra consumer reference since that is a known bug. Anything
more indicates possibly another issue and we probably don't want to
silently absorb those errors as well.

After this change, pools with extra consumer reference should be able to
destroy normally.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…ce on the pool account (paritytech#4503)

addresses paritytech#4440 (will
close once we have this in prod runtimes).
related: paritytech#2037.

An extra consumer reference is preventing pools to be destroyed. When a
pool is ready to be destroyed, we
can safely clear the consumer references if any. Notably, I only check
for one extra consumer reference since that is a known bug. Anything
more indicates possibly another issue and we probably don't want to
silently absorb those errors as well.

After this change, pools with extra consumer reference should be able to
destroy normally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants