generated from polkadot-developers/substrate-parachain-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the sender parallel #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
reviewed
Jun 20, 2023
pepoviola
reviewed
Jun 20, 2023
Thanks for the comments @pepoviola ! All of them should be addressed by now. |
pepoviola
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
This PR makes the
sender
support parallel execution. Normal usage is still supported, however.Parallelism is supported by leveraging the same logic, but by replacing the
sender_index
with a thread index, given that the number of threads passed as an argument to the sender is > 1.Because there was a mix of I/O bound and CPU bound tasks related to sending transactions using
subxt
, I split the CPU bound task into aspawn_blocking
section, and used aJoinSet
for the pre-checks which are I/O bound.All the transactions are submitted after all them are signed.
There also had to be changes made to the subxt client (
Api
type here), which was done using theOnlineClient<PolkadotConfig>::from_rpc()
method, taking anArc<RpcClient>
as an argument. This is because the defaultOnlineClient
does not support the number of concurrent requests required when thesender
in parallel submits all the transactions. Therefore, the client has to be built with theWsClientBuilder
from jsonrpsee to set themax_concurrent_requests
parameter in stead. Currently, themax_concurrent_requests
is set tou32::MAX
.