Unexpected deposit event duplicates after privatenet node 0.9.12 update.

[bors2908]

Hi!

Recently I've been testing an 0.9.12 node update and found a strange issue:

If I am sending a multisig transaction and trying to monitor respective events, API returns new unexpected ones:
duplicates

• second Deposit balances event with the same content
• new Deposit balances event which has the same amount as the Deposit treasury event

and unknown events

• new Deposit balances event with unknown amount (does not include as a fee) and main cosigner address in it.

which were not the case with 0.9.11 node.

Node was launched in Ubuntu Docker under x86-64.

Events examples below.

Thank you!

Example events list in 0.9.11:

After 1st multisig tx

{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'treasury',
index: '0x1306',
data: [ '192,779,719' ]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0504',
data: [
'15Jbynf3EcRqdHV1K14LXYh7PQFTbp5wiXfrc4kbMReR9KxA',
'48,194,930'
]
},
topics: []
}

After 2nd multisig tx

{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'treasury',
index: '0x1306',
data: [ '264,353,161' ]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0504',
data: [
'15Jbynf3EcRqdHV1K14LXYh7PQFTbp5wiXfrc4kbMReR9KxA',
'66,088,291'
]
},
topics: []
}

0.9.12

After 1st multisig tx

{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'14in5CMUV7RnkDUQzPtPSJEqpo3xQ2aQe8u4GFcfzBCforJ3',
'76,166,438'
]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'13UVJyLnbVp9RBZYFwFGyDvVd1y27Tt8tkntv6Q7JVPhFsTB',
'192,377,849'
]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'treasury',
index: '0x1306',
data: [ '192,377,849' ]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'15Jbynf3EcRqdHV1K14LXYh7PQFTbp5wiXfrc4kbMReR9KxA',
'48,094,463'
]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'15Jbynf3EcRqdHV1K14LXYh7PQFTbp5wiXfrc4kbMReR9KxA',
'48,094,463'
]
},
topics: []
}

After 2nd multisig tx

{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'13UVJyLnbVp9RBZYFwFGyDvVd1y27Tt8tkntv6Q7JVPhFsTB',
'263,868,060'
]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'treasury',
index: '0x1306',
data: [ '263,868,060' ]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'15Jbynf3EcRqdHV1K14LXYh7PQFTbp5wiXfrc4kbMReR9KxA',
'65,967,016'
]
},
topics: []
}
{
phase: { ApplyExtrinsic: '2' },
event: {
method: 'Deposit',
section: 'balances',
index: '0x0507',
data: [
'15Jbynf3EcRqdHV1K14LXYh7PQFTbp5wiXfrc4kbMReR9KxA',
'65,967,016'
]
},
topics: []
}

[joepetrowski]

This is due to paritytech/substrate#9425. The transaction fee always emitted two events: one for the deposit to Treasury and the second for the deposit to the block author. That should be removed with 9425 included.

Indeed on Westend v9120 the transaction fee gets logged twice:

[apopiak]

This is not a bug, but the expected behavior of having a Deposit event in both the balances as well as the treasury pallet. (You can see that the "section" differs.)
Edit: Sorry, I thought you were referencing the duplicates between treasury and balances. Not the duplicates for the block author. We can have a look.