Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #6912 #1784

Merged
7 commits merged into from
Oct 30, 2020
Merged

Companion for #6912 #1784

7 commits merged into from
Oct 30, 2020

Conversation

weichweich
Copy link
Contributor

@weichweich weichweich mentioned this pull request Oct 5, 2020
Merged
@athei athei added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Oct 5, 2020
athei
athei approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athei athei added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. B0-silent Changes should not be mentioned in any release notes and removed B1-releasenotes labels Oct 5, 2020
gui1117
gui1117 reviewed Oct 30, 2020
View reviewed changes
runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
runtime/polkadot/src/lib.rs Outdated Show resolved Hide resolved
weichweich and others added 2 commits October 30, 2020 13:01
@weichweich @gui1117
Update runtime/kusama/src/lib.rs
b3e93d0 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@weichweich @gui1117
Apply suggestions from code review
c6894fb 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@ghost
Copy link

ghost commented Oct 30, 2020

Waiting for commit status.

@gui1117
Copy link
Contributor

gui1117 commented Oct 30, 2020 •
edited

ah can you upgrade substrate ? I merged on substrate.

@gui1117
Copy link
Contributor

gui1117 commented Oct 30, 2020 •
edited

you can do cargo update -p sp-io

@gui1117
Copy link
Contributor

gui1117 commented Oct 30, 2020

bot merge

@ghost
Copy link

ghost commented Oct 30, 2020

Trying merge.

@ghost ghost merged commit d9f2cbe into paritytech:master Oct 30, 2020
@weichweich weichweich deleted the aw-decoupled-tx-payment-companion branch October 30, 2020 12:59
ordian added a commit that referenced this pull request Nov 2, 2020
@ordian
Merge branch 'master' into ao-more-resilient-subsystems-av-store
206713f 
* master:
  Adder collator improvements (#1896)
  Fixes bug that collator wasn't sending `Declare` message (#1895)
  fix service build: enable notifications protocol only under real overseer (#1894)
  Adds test parachain adder collator  (#1864)
  A real overseer feature (#1892)
  Implementer's guide: Approval Voting Subsystem (#1691)
  Companion for #6912 (#1784)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weichweich @gui1117 @athei @paritytech-ci