This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Request based availability distribution #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on the requesting side of things.
as I will likely replace it with something smarter.
and getting things to type check.
github-actions
bot
added
the
A3-in_progress
ordian
reviewed
Feb 11, 2021
- Compile fixes. - Cleanup.
Missing: - Check for cancel - Actual querying of peer ids.
- also make it impossible to check the wrong chunk index. - Export needed function in validator_discovery.
Also make sure to not fetch our own chunk.
- FetchTask::is_finished - SessionCache::fetch_session_info
adder-collator is running!
This was referenced Feb 24, 2021
|
I filed follow-up issues for the two points I raised: |
uh perfect, then tests now :-) |
ordian
reviewed
Feb 25, 2021
rphmeier
reviewed
Feb 26, 2021
| @@ -1562,7 +1535,7 @@ mod tests { | |||
| AllMessages::ChainApi(_) => unreachable!("Not interested in network events"), | |||
| AllMessages::CollatorProtocol(_) => unreachable!("Not interested in network events"), | |||
| AllMessages::StatementDistribution(_) => { cnt += 1; } | |||
| AllMessages::AvailabilityDistribution(_) => { cnt += 1; } | |||
| AllMessages::AvailabilityDistribution(_) => unreachable!("Not interested in network events"), | |||
There was a problem hiding this comment.
This can't be triggered by a malicious node, can it?
There was a problem hiding this comment.
(oh, this is test code 👍 )
rphmeier
approved these changes
Feb 26, 2021
@eskimor Is there an issue open for adding back the jaeger spans that we can track? |
|
Good catch - no, it is just on my list. Will make an issue: #2551 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR went large, because I took the occasion to make
ValidatorIndexa newtype wrapper, which is quite invasive in test code.What it does in a nutshell:
Status: Tested manually and seems to work fine (adder-collator).
Still missing in this PR: