Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update to latest Substrate master + warning fixes #292

Merged
merged 2 commits into from Jun 20, 2019
Merged

Update to latest Substrate master + warning fixes #292

merged 2 commits into from Jun 20, 2019

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jun 15, 2019

No description provided.

@bkchr bkchr added the A0-please_review Pull request needs code review. label Jun 15, 2019
@bkchr bkchr requested a review from gavofyork June 15, 2019 10:46
thiolliere
thiolliere reviewed Jun 17, 2019
View reviewed changes
Copy link
Contributor

@thiolliere thiolliere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I really can't tell about most changes

runtime/src/lib.rs Outdated Show resolved Hide resolved
@bkchr @thiolliere
Update runtime/src/lib.rs
06dd30e 
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>
@rphmeier rphmeier merged commit cf7b456 into master Jun 20, 2019
@rphmeier rphmeier deleted the bkchr-update-substrate-4 branch June 20, 2019 11:58
tomusdrw pushed a commit that referenced this pull request Mar 26, 2021
@HCastano
Remove old Substrate pallet (#292)
cc8e2cf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thiolliere thiolliere thiolliere left review comments

@rphmeier rphmeier rphmeier approved these changes

@gavofyork gavofyork Awaiting requested review from gavofyork

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @rphmeier @thiolliere