This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce polkadot code substitute #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a code substitute for the on-chain wasm of Polkadot from block `0x86aa36a140dfc449c30dbce16ce0fea33d5c3786766baa764e33f336841b9e29` on wards. The underlying problem was that there exists some miscompilation by the rust compiler in the wasm runtime that results in state mismatches between the native/wasm runtime of the the 0.8.30 release. This resulted in blocks being authored by the native runtime not being importable by nodes using the wasm runtime. The on-chain wasm is replaced by a wasm build from the 0.8.30 using the rustc nightly from 1.03.2021.
andresilva
approved these changes
May 24, 2021
rphmeier
approved these changes
May 24, 2021
|
Any more details about this compiler bug? Just so we can avoid it as well. |
|
For posterity here's how the substitute wasm blob was built: It's built using the exact same code as is on-chain (i.e. v0.8.30 tag), but using rustc 1.52.0-nightly (e37a13cc3 2021-02-28) instead of rustc 1.52.0-nightly (d6eaea1c8 2021-03-14). |
|
Waiting for commit status. |
We don't know yet what the actual problem is. |
ghost
merged commit
s3krit
pushed a commit
that referenced
this pull request
May 25, 2021
* Introduce polkadot code substitute This introduces a code substitute for the on-chain wasm of Polkadot from block `0x86aa36a140dfc449c30dbce16ce0fea33d5c3786766baa764e33f336841b9e29` on wards. The underlying problem was that there exists some miscompilation by the rust compiler in the wasm runtime that results in state mismatches between the native/wasm runtime of the the 0.8.30 release. This resulted in blocks being authored by the native runtime not being importable by nodes using the wasm runtime. The on-chain wasm is replaced by a wasm build from the 0.8.30 using the rustc nightly from 1.03.2021. * update the wasm substitute blob * update Substrate Co-authored-by: André Silva <andrerfosilva@gmail.com> Co-authored-by: parity-processbot <>
This was referenced Jun 25, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a code substitute for the on-chain wasm of Polkadot from
block
0x86aa36a140dfc449c30dbce16ce0fea33d5c3786766baa764e33f336841b9e29on wards. The underlying problem was that there exists some
miscompilation by the rust compiler in the wasm runtime that results in
state mismatches between the native/wasm runtime of the
the 0.8.30 release. This resulted in blocks being authored by the native
runtime not being importable by nodes using the wasm runtime. The
on-chain wasm is replaced by a wasm build from the 0.8.30 using the
rustc nightly from 1.03.2021.