This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Companion for #8793 (Simple MaxEncodedLen) #3118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
approved these changes
May 26, 2021
Error: Companion update failed: Command 'Command { std: "cargo" "update" "-vp" "sp-io", kill_on_drop: false }' failed with status Some(101); output: error: failed to read Caused by: |
shawntabrizi
added
C1-low
PR touches the given topic and has a low impact on builders.
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
B7-runtimenoteworthy
labels
May 28, 2021
bkchr
approved these changes
May 28, 2021
bot merge |
Waiting for commit status. |
ghost
deleted the
shawntabrizi-simple-max-encoded-len
branch
May 28, 2021 20:50
This was referenced Jun 25, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#8793
This PR should have no affects on the logic or the behavior of the runtime. Only use
BoundedVec
and implementMaxEncodedLen
for some pallets.MaxEncodedLen
is not quite used yet.