Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #8793 (Simple MaxEncodedLen) #3118

Merged
7 commits merged into from
May 28, 2021

Conversation

shawntabrizi
Copy link
Contributor

@shawntabrizi shawntabrizi commented May 26, 2021

paritytech/substrate#8793

This PR should have no affects on the logic or the behavior of the runtime. Only use BoundedVec and implement MaxEncodedLen for some pallets.

MaxEncodedLen is not quite used yet.

@shawntabrizi shawntabrizi added this to In progress in Runtime via automation May 26, 2021
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 26, 2021
Runtime automation moved this from In progress to Needs Audit May 26, 2021
@ghost
Copy link

ghost commented May 28, 2021

Error: Companion update failed: Command 'Command { std: "cargo" "update" "-vp" "sp-io", kill_on_drop: false }' failed with status Some(101); output: error: failed to read /builds/max-encoded-len/Cargo.toml

Caused by:
No such file or directory (os error 2)

@shawntabrizi shawntabrizi added C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. B7-runtimenoteworthy labels May 28, 2021
@shawntabrizi
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented May 28, 2021

Waiting for commit status.

@ghost ghost merged commit b4be9c2 into master May 28, 2021
Runtime automation moved this from Needs Audit to Done May 28, 2021
@ghost ghost deleted the shawntabrizi-simple-max-encoded-len branch May 28, 2021 20:50
@shawntabrizi shawntabrizi moved this from Done to Archive in Runtime Jul 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
Runtime
Archive
Development

Successfully merging this pull request may close these issues.

None yet

3 participants