Crowdfund parachain deposit

[gavofyork]

No description provided.

[gavofyork]

@shawntabrizi would be good to get tests in for funds that span multiple auctions and funds that begin prior to any auction.

[shawntabrizi]

@shawntabrizi would be good to get tests in for funds that span multiple auctions and funds that begin prior to any auction.

Yes, I can do this asap.

[shawntabrizi]

my general feeling is that runtime correctness checks should only be conducted when there's no possibility of making a static correctness check. in cases where it's demonstrably impossible or impractical for an error to be triggered then i'm against littering the code.

This makes sense to me, but now I struggle to understand how best to teach a concept like this to new runtime developers. Will follow up with you offline.

does it also do exactly the right thing when the fund happens over multiple auctions?

You are right it does not work over multiple auctions. The updated logic you introduced makes sense to me, and handles this situation well. I will write tests to check it.

[shawntabrizi]

@gavofyork a crowdfund with an end date longer than a single auction seems to work with the last test I added. However, from one action end to the next auction, there must be a contribution to the fund in order for it to be added to NewRaise again, and submit a bid.

Is this okay?

[gavofyork]

The decision on when/whether to place an item in NewRaise should be tested thoroughly... Does it check when the fund has a bid outside of an ending period, then in a later auction, also outside the ending period, a winning bid?

[gavofyork]

ok - i'm reasonably happy with it.

[gavofyork]

@shawntabrizi once you're happy with it, give it a final review and we can merge.

[shawntabrizi]

Note: Right now only create has a transaction weight. Could need a follow up after doing analysis on the functions.