This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Removed unneeded deps #3658
Merged
Removed unneeded deps #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
A3-in_progress
gilescope
requested review from
HCastano,
svyatonik and
tomusdrw
as code owners
gilescope
added
A0-please_review
HCastano
reviewed
Aug 20, 2021
|
Great idea - will do.
…On Fri, 20 Aug 2021 at 17:45, Hernando Castano ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bridges/primitives/runtime/Cargo.toml
<#3658 (comment)>:
>
-[dev-dependencies]
-sp-core = { git = "https://github.com/paritytech/substrate", branch = "master" }
+# [dev-dependencies]
+# sp-core = { git = "https://github.com/paritytech/substrate", branch = "master" }
I suspect the reason why this is fine is because the bridge tests don't
get run in the Polkadot repo.
I would avoid touching the bridges code as part of this PR, and instead do
a follow up directly as part of the parity-bridges-common repo to see
what unneeded deps exist there
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3658 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEJCCHL7EHPKMA4XRJ2HLT5Z2CTANCNFSM5CMMF7VQ>
.
|
(we will attempt to do these through the bridges repo)
ordian
reviewed
Aug 21, 2021
drahnr
reviewed
Aug 21, 2021
drahnr
reviewed
Aug 21, 2021
ordian
reviewed
Aug 24, 2021
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
|
@drahnr the line brakes come from vscode's "even better toml" extension that formats toml files (it has a cli too https://github.com/tamasfe/taplo/tree/master/taplo-cli ). I'm keen on something auto-formatting Cargo.toml files and so far that seems to be about the only thing that does. |
…dot into giles-depend-o-pocolipse
gilescope
added
B1-releasenotes
and removed
B0-silent
ordian
approved these changes
Aug 30, 2021
drahnr
approved these changes
Aug 30, 2021
ordian
added a commit
that referenced
this pull request
Sep 2, 2021
* master: dependabot: ignore yet another git dep (#3759) Bump serde_json from 1.0.66 to 1.0.67 (#3767) Bump syn from 1.0.74 to 1.0.75 (#3710) Companion for substrate #9371 (#3487) Fixes/improvements for disputes (#3753) chore: test helper arbitrary ordering for 2 (#3762) disputes: fix relay chain selection sanity check (#3750) technical committee is using the weight of council, but should have its own generated weight instead (#3511) new proxy for auctions, crowdloans, registrar, slots (#3683) Bump libc from 0.2.100 to 0.2.101 (#3726) Removed unneeded deps (#3658) Bump serde from 1.0.127 to 1.0.130 (#3739) Companion for Generate storage info for pallet authority_discovery #9428 (#3517) Return a Result in invert_location (#3730) XCM: Allow reclaim of assets dropped from holding (#3727)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentatively these deps seem not to be needed.