This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
add parachains pallets to Polkadot runtime #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
rphmeier
commented
Sep 8, 2021
runtime/polkadot/src/lib.rs
Outdated
| @@ -1130,48 +1277,63 @@ pub type Executive = frame_executive::Executive< | |||
| frame_system::ChainContext<Runtime>, | |||
| Runtime, | |||
| AllPallets, | |||
| TechnicalMembershipStoragePrefixMigration, | |||
There was a problem hiding this comment.
Did I remove this prematurely or was it good to remove?
There was a problem hiding this comment.
On the current Polkadot network (9090), this migration has NOT happened yet.
Will these changes go into v0.9.10? If so, then yeah, we should have both in there.
rphmeier
added
the
D9-needsaudit 👮
pepyakin
reviewed
Sep 9, 2021
| hrmp_max_parachain_inbound_channels: 10, | ||
| hrmp_max_parathread_inbound_channels: 0, | ||
| hrmp_channel_max_message_size: 102_400, | ||
| code_retention_period: EPOCH_DURATION_IN_SLOTS * 6, |
There was a problem hiding this comment.
What's the rationale for this number?
There was a problem hiding this comment.
AFAIK Code needs to be available for the entire dispute period, which is 6 epochs.
Comment on lines
+1420
to
+1421
| hrmp_sender_deposit: deposit(1004, 100 * 1024), | ||
| hrmp_recipient_deposit: deposit(1004, 100 * 1024), |
There was a problem hiding this comment.
This will be a massive deposit. 20,000 DOT at least (1004 * 20 * DOLLARS), then we also have to add cost of bytes.
How was this determined?
There was a problem hiding this comment.
Yeah, that's a TODO - it's the same as the Kusama values which are themselves too large.
|
/benchmark runtime polkadot runtime_common::crowdloan |
|
Benchmark Runtime Polkadot Pallet for branch "rh-add-polkadot-parachains-pallets" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_crowdloan.rs Results |
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_crowdloan.rs
|
/benchmark runtime polkadot runtime_common::crowdloan |
|
Benchmark Runtime Polkadot Pallet for branch "rh-add-polkadot-parachains-pallets" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_crowdloan.rs Results |
…rh-add-polkadot-parachains-pallets
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::crowdloan --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_crowdloan.rs
…om/paritytech/polkadot into rh-add-polkadot-parachains-pallets
|
/benchmark runtime polkadot runtime_common::paras_registrar |
|
Benchmark Runtime Polkadot Pallet for branch "rh-add-polkadot-parachains-pallets" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::paras_registrar --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_paras_registrar.rs Results |
…rh-add-polkadot-parachains-pallets
…k --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::paras_registrar --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_paras_registrar.rs
|
/benchmark runtime polkadot runtime_common::slots |
|
Benchmark Runtime Polkadot Pallet for branch "rh-add-polkadot-parachains-pallets" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::slots --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_slots.rs ResultsERROR: Unable to push ./runtime/polkadot/src/weights/runtime_common_slots.rs |
|
/benchmark runtime polkadot runtime_common::auctions |
|
Benchmark Runtime Polkadot Pallet for branch "rh-add-polkadot-parachains-pallets" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_common::auctions --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_common_auctions.rs ResultsERROR: Unable to commit file ./runtime/polkadot/src/weights/runtime_common_auctions.rs |
jakoblell
added
D1-audited 👍
shawntabrizi
approved these changes
Sep 23, 2021
ordian
added a commit
that referenced
this pull request
Sep 28, 2021
* master: (24 commits) Added multisig in Rococo (#3873) Fix bin-substrate toml (#3939) Bump tracing from 0.1.27 to 0.1.28 (#3937) XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818) Bump libc from 0.2.101 to 0.2.102 (#3933) Do not compile `wasm_api` module when not needed. (#3934) Bump syn from 1.0.76 to 1.0.77 (#3932) Fix spelling (#3845) Bump tokio from 1.11.0 to 1.12.0 (#3910) Ignore `generate-bags` by dependabot (#3930) Update logging in paras_inherent (#3927) Bump libsecp256k1 from 0.6.0 to 0.7.0 (#3909) Remove BEEFY repo dependency (#3923) Substrate Companion for rust 1.54 (#3807) Fix broken links (#3919) update BaseXcmWegiht to match Kusama (#3911) add parachains pallets to Polkadot runtime (#3815) Add a `force_unfreeze` extrinsic to the disputes module (#3906) Add new rococo chainspec (#3905) Ensure all parachain configuration extrinsics are operational (#3912) ...
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some TODOs w.r.t. crowdloan deposits, but that can be changed later.