This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Dispatchable XCMs should translate to v0 #4062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
B7-runtimenoteworthy
D2-notlive 💤
KiChjang
approved these changes
Oct 12, 2021
KiChjang
reviewed
Oct 12, 2021
Comment on lines
+530
to
+531
| BuyExecution { fees, weight_limit: Limited(0) }, | ||
| DepositAsset { assets: Wild(All), max_assets, beneficiary }, |
There was a problem hiding this comment.
I think I should put this in the README for XCMv2, highlighting that it's very important for Weigher implementations to give proper weights for BuyExecution and DepositAsset.
There was a problem hiding this comment.
Yeah - as long as chains are on v1/v0, they must use the same (or lower) weights as Kusama.
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
* master: (40 commits) use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071) Move runtime to with_transaction in order to Rollback state changes (#4067) Update wasmtime config to match new version in substrate (#4063) Fix XCM Weights on Westend (#4066) Dispatchable XCMs should translate to v0 (#4062) Add xcm fuzzer (#3869) Bump trybuild from 1.0.49 to 1.0.50 (#4060) Companion PR for ss58 crate (#3953) overseer: simplify debugging some more (#4053) Bump thiserror from 1.0.29 to 1.0.30 (#4048) Bump strum from 0.21.0 to 0.22.0 (#4047) Add para pallets to polkadot benchmarks (#4045) Fixes broken docker link in docker descriptiob (#4043) Bump trybuild from 1.0.48 to 1.0.49 (#4039) ...
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Dispatchable XCMs should translate to v0 * Formatting * Update Westend's XCM WrapVersion
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, XCMs sendable from the XCM pallet could not be translated to v1/v0. This makes a quick fix.
It also switches the
WrapVersionimpl for Kusama/Rococo to XCM pallet, allowing for v2 -> v2 messages on destinations that support it.