Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update wasmtime config to match new version in substrate #4063

Merged
3 commits merged into from Oct 12, 2021

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Oct 12, 2021

No description provided.

@@ -65,6 +68,7 @@ const CONFIG: Config = Config {
native_stack_max: 256 * 1024 * 1024,
}),
canonicalize_nans: true,
parallel_compilation: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want single-threaded compilation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to turn it on when performing PVF prechecking, it can be introduced here (pass different semantics):

sc_executor_wasmtime::prepare_runtime_artifact(blob, &CONFIG.semantics)

Otherwise, the multithreaded behavior remains

@ordian ordian requested a review from pepyakin October 12, 2021 11:38
@ghost
Copy link

ghost commented Oct 12, 2021

Waiting for commit status.

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 12, 2021
@ghost ghost merged commit 7319f58 into master Oct 12, 2021
@ghost ghost deleted the slumber-update-substrate-wasmtime branch October 12, 2021 15:56
ordian added a commit that referenced this pull request Oct 14, 2021
* master: (40 commits)
  use pipeline-scripts for dependent projects script (#4017)
  companion for substrate/10013 (#4078)
  fix restart issue of staking miner (#4073)
  use `WEIGHT_PER_SECOND` (#4077)
  Switch to compressed runtimes (#4061)
  Create a README for XCMv1 detailing notable changes (#4058)
  Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
  Move runtime to with_transaction in order to Rollback state changes (#4067)
  Update wasmtime config to match new version in substrate (#4063)
  Fix XCM Weights on Westend (#4066)
  Dispatchable XCMs should translate to v0 (#4062)
  Add xcm fuzzer (#3869)
  Bump trybuild from 1.0.49 to 1.0.50 (#4060)
  Companion PR for ss58 crate (#3953)
  overseer: simplify debugging some more (#4053)
  Bump thiserror from 1.0.29 to 1.0.30 (#4048)
  Bump strum from 0.21.0 to 0.22.0 (#4047)
  Add para pallets to polkadot benchmarks (#4045)
  Fixes broken docker link in docker descriptiob (#4043)
  Bump trybuild from 1.0.48 to 1.0.49 (#4039)
  ...
emostov pushed a commit that referenced this pull request Nov 1, 2021
* Update wasmtime config to match new version

* update Substrate

Co-authored-by: parity-processbot <>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants