Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix weights on hard-coded XCM fragments #4144

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Oct 25, 2021

Fix for weights. Also adds dispatch variants for providing weight manually.

cc @shawntabrizi @KiChjang

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Oct 25, 2021
@gavofyork gavofyork added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Oct 25, 2021
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I think this is okay, but I do think some kind of holistic approach in solving the weight fee payment problem is needed.

An idea that I just came up with is to have something similar to version negotiation, we can have a storage item that stores the fee schedule for known parachains, and perhaps we could also have a new XCM instruction that specifically asks for this sort of data.

@gavofyork
Copy link
Member Author

The main problem with that is that the fee schedule may be non-linear; for now it would work, and perhaps that's good enough. Another possibility is to have the UI discover and include the destination weight through an exported WASM of the Weigher crate of the destination chain.

@gavofyork gavofyork merged commit c095ab9 into master Oct 26, 2021
@gavofyork gavofyork deleted the gav-fix-weight-on-hard-xcm branch October 26, 2021 10:36
KiChjang pushed a commit that referenced this pull request Oct 27, 2021
* Fix weights on hard-coded XCM fragments

* Formatting
joepetrowski pushed a commit that referenced this pull request Oct 27, 2021
* Fix weights on hard-coded XCM fragments

* Formatting

Co-authored-by: Gavin Wood <gavin@parity.io>
ordian added a commit that referenced this pull request Oct 27, 2021
* master: (73 commits)
  Fix XCM Teleport Benchmark (#4146)
  Allow Queries and Subscriptions (#4150)
  Fix weights on hard-coded XCM fragments (#4144)
  Bump spec versions (#4142)
  Bump libc from 0.2.104 to 0.2.105 (#4141)
  Enable bags-list pallet in polkadot (#4080)
  Move artifacts states into memory in PVF validation host (#3907)
  Introduce new Runtime API endpoint for fetching the validation data (#3728)
  export xcm_pallet config (#4116)
  Apply cargo fmt (#4122)
  remove logging from the check-dependent-* job (#4120)
  Remove stale migrations (#4107)
  Bump structopt from 0.3.23 to 0.3.25 (#4098)
  remove hardcoded pipeline scripts tag (#4109)
  Bump libc from 0.2.103 to 0.2.104 (#4099)
  some spelling fixes (#4088)
  polkadot: remove call filters on registrar pallets (#4093)
  Fix typos in docs (#4092)
  Rename Statemint where appropriate (#4087)
  bump substrate (#4091)
  ...
emostov pushed a commit that referenced this pull request Nov 1, 2021
* Fix weights on hard-coded XCM fragments

* Formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants