This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
approval-voting: query finalized block on startup and increase look back #4705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed on Rococo when the spec was generated with the broken
SessionInfo
definition and the runtime API for it has failed,it led to a few missing block entries in the approval-voting
db, which in turn resulted in the finality stall.
Upgrading the runtime and restarting the nodes didn't fill the gap in
the missing blocks because there were no finality notifications
and the runtime api cached
None
for session info (fixed in the next PR).This PR should also result in a more robust approval voting for small
testnets with nodes restarting.