This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
approval-voting: query finalized block on startup and increase look back #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Jan 12, 2022
ordian
added
B0-silent
ordian
force-pushed
the
ao-approval-voting-logs
branch
from
662697d
to
36d2715
Compare
ordian
force-pushed
the
ao-approval-voting-look-back
branch
from
42b27b0
to
7a195db
Compare
rphmeier
approved these changes
Jan 12, 2022
ordian
force-pushed
the
ao-approval-voting-look-back
branch
from
7a195db
to
c4b4d84
Compare
|
bot merge |
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
…ack (paritytech#4705) * approval-voting: add more logs * approval-voting: query finalized block on startup and increase look back
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed on Rococo when the spec was generated with the broken
SessionInfodefinition and the runtime API for it has failed,it led to a few missing block entries in the approval-voting
db, which in turn resulted in the finality stall.
Upgrading the runtime and restarting the nodes didn't fill the gap in
the missing blocks because there were no finality notifications
and the runtime api cached
Nonefor session info (fixed in the next PR).This PR should also result in a more robust approval voting for small
testnets with nodes restarting.