Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Switch to edition 2021 #4976

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Switch to edition 2021 #4976

merged 5 commits into from
Feb 24, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 23, 2022

Switch to rust edition 2021.

@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Feb 23, 2022
KiChjang
KiChjang approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely understanding the switch to V1 in messages_benchmarking, but everything else luks gud.

@drahnr
Copy link
Contributor

drahnr commented Feb 24, 2022 •
edited
Loading

Not entirely understanding the switch to V1 in messages_benchmarking, but everything else luks gud.

It's the bridges dir, which is a subtree and didn't build before.

The new feature resolution seems to have broken the test-runtime.

@paritytech paritytech deleted a comment from paritytech-processbot bot Feb 24, 2022
@bkchr
Copy link
Member Author

bkchr commented Feb 24, 2022

Not entirely understanding the switch to V1 in messages_benchmarking, but everything else luks gud.

The same change was done in bridges repo also already.

@drahnr
Copy link
Contributor

drahnr commented Feb 24, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 645ae55 into master Feb 24, 2022
@paritytech-processbot paritytech-processbot bot deleted the bkchr-edition-2021 branch February 24, 2022 10:20
This was referenced Feb 25, 2022
Merged
Closed
@sandreim sandreim mentioned this pull request Sep 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@KiChjang KiChjang KiChjang approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@svyatonik svyatonik Awaiting requested review from svyatonik

@acatangiu acatangiu Awaiting requested review from acatangiu

@antonio-dropulic antonio-dropulic Awaiting requested review from antonio-dropulic

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @drahnr @shawntabrizi @KiChjang