This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
create .github/pr-custom-review.yml #5253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-paulo-parity
changed the title
joao-paulo-parity
added
A2-insubstantial
joao-paulo-parity
force-pushed
the
jp/pr-custom-review-config
branch
from
14b9725
to
9b67d3e
Compare
sergejparity
approved these changes
Apr 5, 2022
This was referenced Apr 7, 2022
| - name: Runtime files | ||
| check_type: changed_files | ||
| condition: ^runtime/(kusama|polkadot)/src/[^/]+\.rs$ | ||
| all_distinct: |
There was a problem hiding this comment.
@bkchr to make the review work like you suggest in paritytech/pr-custom-review#81 (comment) for this rule, change this line
Suggested change
| all_distinct: | |
| all: |
It would not affect 🔒 lines however
ordian
added a commit
that referenced
this pull request
Apr 13, 2022
* master: (62 commits) Bump tracing from 0.1.32 to 0.1.33 (#5299) Add staging runtime api (#5048) CI: rename ambiguous jobs (#5313) Prepare for rust 1.60 (#5282) Bump proc-macro2 from 1.0.36 to 1.0.37 (#5265) Fixes the dead lock when any of the channels get at capacity. (#5297) Bump syn from 1.0.90 to 1.0.91 (#5273) create .github/workflows/pr-custom-review.yml (#5280) [ci] fix pallet benchmark script (#5247) (#5292) bump spec_version to 9190 (#5291) bump version to 0.9.19 (#5290) Session is actually ancient not unknown. (#5286) [ci] point benchmark script to sub-commands (#5247) (#5289) Remove Travis CI (#5287) Improve error handling in approval voting block import (#5283) fix .github/pr-custom-review.yml (#5279) Co #11164: Sub-commands for `benchmark` (#5247) Bump clap from 3.1.6 to 3.1.8 (#5240) Custom Slots Migration for Fund Index Change (#5227) create pr-custom-review.yml (#5253) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the requirements discussed in paritytech/pr-custom-review#67. Feel free to comment there for any disagreements.
The missing requirement is implemented as a built-in check, therefore it should not be included here.
Creates .github/pr-custom-review.yml
Syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax
Rules in accordance to https://github.com/paritytech/pr-custom-review/pull/67/files#diff-54ea723241231828f6cea5e58275577fb2860c25d321b75dac6e01c75e5c831b