This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
update weights #5361
Merged
update weights #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderobe
added
A0-please_review
This was referenced Apr 21, 2022
Merged
ggwpez
approved these changes
Apr 21, 2022
chevdor
approved these changes
Apr 22, 2022
Comment on lines
55
to
59
| fn on_initialize_nothing() -> Weight { | ||
| (23_878_000 as Weight).saturating_add(T::DbWeight::get().reads(8 as Weight)) | ||
| (12_441_000 as Weight) | ||
| .saturating_add(T::DbWeight::get().reads(8 as Weight)) | ||
| } | ||
| // Storage: ElectionProviderMultiPhase Round (r:1 w:0) |
There was a problem hiding this comment.
NOTE: Around 50% reduction for the election provider and phragmen
There was a problem hiding this comment.
Yea this is since they were not updated since paritytech/substrate#10692. although they should have been 🤷
Comment on lines
+47
to
+59
| // Storage: PhragmenElection Candidates (r:1 w:0) | ||
| // Storage: PhragmenElection Members (r:1 w:0) | ||
| // Storage: PhragmenElection RunnersUp (r:1 w:0) | ||
| // Storage: PhragmenElection Voting (r:1 w:1) | ||
| // Storage: Balances Locks (r:1 w:1) | ||
| fn vote_equal(v: u32, ) -> Weight { | ||
| (20_639_000 as Weight) | ||
| // Standard Error: 7_000 | ||
| .saturating_add((200_000 as Weight).saturating_mul(v as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(5 as Weight)) | ||
| .saturating_add(T::DbWeight::get().writes(2 as Weight)) | ||
| } | ||
| fn vote_more(v: u32) -> Weight { | ||
| (83_389_000 as Weight) | ||
| .saturating_add((341_000 as Weight).saturating_mul(v as Weight)) | ||
| // Storage: PhragmenElection Candidates (r:1 w:0) |
There was a problem hiding this comment.
NOTE: Around 50% reduction for the election provider and phragmen
There was a problem hiding this comment.
this can likely be attributed to the fact that those weights hadn't been updated in well over a year
Comment on lines
49
to
57
| // Storage: Preimage StatusFor (r:1 w:1) | ||
| // Storage: Scheduler Lookup (r:0 w:1) | ||
| fn on_initialize_periodic_named_resolved(s: u32, ) -> Weight { | ||
| (0 as Weight) | ||
| // Standard Error: 28_000 | ||
| .saturating_add((23_540_000 as Weight).saturating_mul(s as Weight)) | ||
| (1_758_000 as Weight) | ||
| // Standard Error: 30_000 | ||
| .saturating_add((24_061_000 as Weight).saturating_mul(s as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(1 as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(s as Weight))) | ||
| .saturating_add(T::DbWeight::get().writes(1 as Weight)) |
Comment on lines
64
to
70
| fn on_initialize_named_resolved(s: u32, ) -> Weight { | ||
| (1_922_000 as Weight) | ||
| // Standard Error: 21_000 | ||
| .saturating_add((18_731_000 as Weight).saturating_mul(s as Weight)) | ||
| (452_000 as Weight) | ||
| // Standard Error: 29_000 | ||
| .saturating_add((19_512_000 as Weight).saturating_mul(s as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(1 as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads((2 as Weight).saturating_mul(s as Weight))) | ||
| .saturating_add(T::DbWeight::get().writes(1 as Weight)) |
Comment on lines
123
to
129
| fn on_initialize(n: u32, ) -> Weight { | ||
| (2_126_000 as Weight) | ||
| // Standard Error: 19_000 | ||
| .saturating_add((48_336_000 as Weight).saturating_mul(n as Weight)) | ||
| (0 as Weight) | ||
| // Standard Error: 20_000 | ||
| .saturating_add((49_389_000 as Weight).saturating_mul(n as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(5 as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads((5 as Weight).saturating_mul(n as Weight))) | ||
| .saturating_add(T::DbWeight::get().writes(3 as Weight)) |
Comment on lines
45
to
51
| pub struct WeightInfo<T>(PhantomData<T>); | ||
| impl<T: frame_system::Config> frame_system::WeightInfo for WeightInfo<T> { | ||
| fn remark(b: u32, ) -> Weight { | ||
| (0 as Weight) | ||
| (2_551_000 as Weight) | ||
| // Standard Error: 0 | ||
| .saturating_add((1_000 as Weight).saturating_mul(b as Weight)) | ||
| } |
Comment on lines
53
to
65
| // Storage: Staking ForceEra (r:1 w:0) | ||
| // Storage: ElectionProviderMultiPhase CurrentPhase (r:1 w:0) | ||
| fn on_initialize_nothing() -> Weight { | ||
| (23_878_000 as Weight).saturating_add(T::DbWeight::get().reads(8 as Weight)) | ||
| (12_276_000 as Weight) | ||
| .saturating_add(T::DbWeight::get().reads(8 as Weight)) | ||
| } | ||
| // Storage: ElectionProviderMultiPhase Round (r:1 w:0) | ||
| // Storage: ElectionProviderMultiPhase CurrentPhase (r:0 w:1) | ||
| fn on_initialize_open_signed() -> Weight { | ||
| (34_547_000 as Weight) | ||
| (11_448_000 as Weight) | ||
| .saturating_add(T::DbWeight::get().reads(1 as Weight)) | ||
| .saturating_add(T::DbWeight::get().writes(1 as Weight)) | ||
| } |
There was a problem hiding this comment.
50%-ish decrease in pallet
Comment on lines
49
to
57
| // Storage: Preimage StatusFor (r:1 w:1) | ||
| // Storage: Scheduler Lookup (r:0 w:1) | ||
| fn on_initialize_periodic_named_resolved(s: u32, ) -> Weight { | ||
| (0 as Weight) | ||
| // Standard Error: 31_000 | ||
| .saturating_add((23_661_000 as Weight).saturating_mul(s as Weight)) | ||
| (1_442_000 as Weight) | ||
| // Standard Error: 60_000 | ||
| .saturating_add((24_552_000 as Weight).saturating_mul(s as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(1 as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(s as Weight))) | ||
| .saturating_add(T::DbWeight::get().writes(1 as Weight)) |
Comment on lines
74
to
82
| // Storage: Preimage PreimageFor (r:1 w:1) | ||
| // Storage: Preimage StatusFor (r:1 w:1) | ||
| fn on_initialize_periodic_resolved(s: u32, ) -> Weight { | ||
| (847_000 as Weight) | ||
| (34_000 as Weight) | ||
| // Standard Error: 29_000 | ||
| .saturating_add((21_351_000 as Weight).saturating_mul(s as Weight)) | ||
| .saturating_add((22_211_000 as Weight).saturating_mul(s as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(1 as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(s as Weight))) | ||
| .saturating_add(T::DbWeight::get().writes(1 as Weight)) |
Comment on lines
121
to
129
| // Storage: Auctions ReservedAmounts (r:2 w:2) | ||
| // Storage: System Account (r:2 w:2) | ||
| fn on_initialize(n: u32, ) -> Weight { | ||
| (2_735_000 as Weight) | ||
| // Standard Error: 17_000 | ||
| .saturating_add((46_633_000 as Weight).saturating_mul(n as Weight)) | ||
| (0 as Weight) | ||
| // Standard Error: 18_000 | ||
| .saturating_add((49_564_000 as Weight).saturating_mul(n as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads(5 as Weight)) | ||
| .saturating_add(T::DbWeight::get().reads((5 as Weight).saturating_mul(n as Weight))) | ||
| .saturating_add(T::DbWeight::get().writes(3 as Weight)) |
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏋️
see release PR here