Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Co #11456: Expose benchmark extrinsic command #5620

Merged
merged 21 commits into from Jul 19, 2022
Merged

Co #11456: Expose benchmark extrinsic command #5620

merged 21 commits into from Jul 19, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jun 1, 2022 •
edited

Changes:

  • Move benchmarking code out from node/client/src/lib.rs to node/client/src/benchmarking.rs as to not bloat that file
  • Expose benchmark extrinsic and implement it for system remark and balances transfer_keep_alive
  • Add tests

Example usage from the Substrate MR paritytech/substrate#11456:

$ polkadot benchmark extrinsic --pallet system --extrinsic remark --chain polkadot-dev

Creating empty BABE epoch changes on what appears to be first startup.    
Building block, this takes some time...    
Extrinsics per block: 12000    
Running 10 warmups...    
Executing block 100 times    
Executing a SYSTEM::REMARK extrinsic takes[ns]:
Total: 6897382
Min: 68685, Max: 69797
Average: 68973, Median: 68899, Stddev: 188.99
Percentiles 99th, 95th, 75th: 69293, 69230, 69122

Cumulus companion: paritytech/cumulus#1350

@ggwpez
Expose 'benchmark extrinsic' command
b825b5d 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add test
f6d2a68 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 1, 2022
@ggwpez ggwpez mentioned this pull request Jun 1, 2022
Merged
1 task
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jun 1, 2022
@ggwpez
Fix tests
344d40d 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix tests
fc262c7 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Split benchmarking into own mod
cfdb8dc 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Simplify code
d128dc6 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fixup
40b4997 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jun 1, 2022
@ggwpez
Cleanup
877cd80 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-bench-extrinsic
2b4665f
@ggwpez
Spell
cfb3a66 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Revert Cargo.lock updates
b9c8650 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
gilescope
gilescope approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks much better.

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for bcfb744

@ggwpez
Fix brittle test
f907cea 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Bump spec version to 9270
c1c385d 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech-ci paritytech-ci requested a review from a team July 19, 2022 07:35
@ggwpez
Sleep in test to make it work in CI...
9dfb271 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Jul 19, 2022
Closed
@ggwpez
Disable failing test
2d8771c 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Revert "Bump spec version to 9270"
dc87d6d 
This reverts commit c1c385d.
@ggwpez
Delete brittle test, see #5788
b1b4c4a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez removed the request for review from a team July 19, 2022 08:52
@ggwpez
Disable failing test
bfbc6df 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Delete more failing tests...
b7bd7e4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez mentioned this pull request Jul 19, 2022
Closed
@ggwpez ggwpez merged commit 9c64ccd into master Jul 19, 2022
@ggwpez ggwpez deleted the oty-bench-extrinsic branch July 19, 2022 12:11
ordian added a commit that referenced this pull request Jul 22, 2022
@ordian
Merge branch 'master' into ao-malus-delay-finality
c31de45 
* master:
  westend xcm: collectives parachain is trusted teleporter (#5798)
  Cleanup light client leftovers (#5794)
  Fix benchmarking tests (#5791)
  allow re-use and avoid compiling kusama parachain code (#5792)
  Introduce async runtime calling trait for runtime-api subsystem (#5782)
  add `Extrinsic Ordering` check that runs against a local reference node (#5790)
  Co #11456: Expose `benchmark extrinsic` command (#5620)
  `staking-miner`:  Add handling of `SIGTERM`, `SIGKILL`, `SIGQUIT` and `SIGINT` (#5780)
  Zombienet: paritydb test (#5310)
  Fix Typo (#5766)
  Fix Core Version display in the release notes (#5781)
  companion for new pools reward scheme (#5757)
  fix disable-runtime-api feature flag (#5773)
  split NetworkBridge into two subsystems (#5616)
  Implement prune only stagnant check mode (#5761)
ordian added a commit that referenced this pull request Jul 28, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
95cd87d 
* master: (37 commits)
  Backport crate version bumps to 0.9.27 (#5826)
  Fix GHA (#5825)
  [ci] Add timeout to benchmark jobs (#5822)
  Parachains db column "migration" (#5797)
  Companion for #11831 (#5784)
  [ci] Return production image (#5818)
  add migration for staking v10 (#5817)
  Prepare for rust 1.62.1 (#5811)
  Bump strum to 0.24.1 (#5816)
  Bump substrate (#5814)
  Add missing trigger wildcards for some CI workflows (#5812)
  malus: add `finality_delay` cli flag (#5770)
  [ci] publish parachain-implementers-guide (#5806)
  westend xcm: collectives parachain is trusted teleporter (#5798)
  Cleanup light client leftovers (#5794)
  Fix benchmarking tests (#5791)
  allow re-use and avoid compiling kusama parachain code (#5792)
  Introduce async runtime calling trait for runtime-api subsystem (#5782)
  add `Extrinsic Ordering` check that runs against a local reference node (#5790)
  Co #11456: Expose `benchmark extrinsic` command (#5620)
  ...
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@coderobe coderobe coderobe approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ggwpez @gilescope @shawntabrizi @coderobe