This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Revert "Introduce Tinkernet multisig XCM configs to Kusama/Rococo through xcm-builder" #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
added
A0-please_review
ggwpez
approved these changes
Jun 30, 2023
franciscoaguirre
approved these changes
Jun 30, 2023
liamaharon
approved these changes
Jun 30, 2023
bkchr
approved these changes
Jun 30, 2023
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7165
Items specific to Kusama which go into common crates like
xcm-buildershould:a) be placed in a Kusama-specific path or have "Kusama" clearly placed in its name; and
b) convert the
MultiLocationvalue to be universal and then that used for matching.This code makes little sense outside of the very specific context it is designed for. In particular, matching code like
parents: _is not tight enough, especially when combined with a non-consensus-specificParachainjunction matcher. First converting into a universal location and then matching on that would alleviate these issues.Once the runtimes are moved out into the Fellowship repo, this code should be, too. For now it can reasonably live next to the runtime, but it's just too inherently opinionated to be placed in
xcm-builder.