This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove Polkadot & Kusama native runtime #7467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it: 1. There are no more `kusama/polkadot-dev` chain specs available. We will need to write some tooling in the fellowship repo to provide them easily. 2. The `try-runtime` job for polkadot & kusama is not available anymore as we don't have the dev chain specs anymore. 3. Certain benchmarking commands will also not work until we migrate them to use a runtime api. Some crates in `utils` are still depending on the polkadot/kusama native runtime that will also need to be fixed.
bkchr
added
A0-please_review
ordian
approved these changes
Aug 16, 2023
s0me0ne-unkn0wn
approved these changes
Aug 16, 2023
| use pallet_im_online::sr25519::AuthorityId as ImOnlineId; | ||
| #[cfg(any( | ||
| feature = "polkadot-native", |
There was a problem hiding this comment.
Seems like any() is redundant now?
| @@ -53,14 +41,10 @@ use serde::{Deserialize, Serialize}; | |||
| use sp_core::{sr25519, Pair, Public}; | |||
| use sp_runtime::traits::IdentifyAccount; | |||
| #[cfg(any( | |||
| feature = "polkadot-native", | |||
ggwpez
approved these changes
Aug 16, 2023
|
As @bkontur points out we will need a cumulus companion PR for this PR as the cumulus integration tests depend on these runtimes. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
sergejparity
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the Polkadot and Kusama native runtime from the polkadot node. This brings some implications with it:
There are no more
kusama/polkadot-devchain specs available. We will need to write some tooling in the fellowship repo to provide them easily.The
try-runtimejob for polkadot & kusama is not available anymore as we don't have the dev chain specs anymore.Certain benchmarking commands will also not work until we migrate them to use a runtime api.
Some crates in
utilsare still depending on the polkadot/kusama native runtime that will also need to be fixed.