Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Introduce Tinkernet multisig XCM configs to xcm-builder #7490

Closed
wants to merge 3 commits into from
Closed

Introduce Tinkernet multisig XCM configs to xcm-builder #7490

wants to merge 3 commits into from

Conversation

arrudagates
Copy link
Contributor

This PR is a second attempt at introducing the Tinkernet XCM configs into xcm-builder and the Kusama/Rococo runtimes. For more information, refer to the original PR #7165.

This new PR comes with small changes to the location of the configs within xcm-builder in an attempt to make their relation to Kusama and Kusama parachains more explicit.

I also welcome discussions on different ways to implement this, particularly the point made by @gavofyork that these should make use of UniversalOrigin (#7165 (comment)), however it is not very clear from existing XCM documentation how this is supposed to work, and it appears it's not supported in Kusama/Rococo yet (#7165 (comment))

@paritytech-ci paritytech-ci requested review from a team July 11, 2023 17:41
@arrudagates
Copy link
Contributor Author

@ggwpez @sam0x17 @KiChjang @kianenigma @rphmeier
Since you reviewed the previous PR, I would like for you join discussions and, if possible, continue to provide reviews for this one.

@arrudagates arrudagates changed the title Introduce Tinkernet multisig XCM configs - Second Attempt Introduce Tinkernet multisig XCM configs to xcm-builder Jul 24, 2023
@arrudagates
Copy link
Contributor Author

Implementation of the configs in the Kusama/Rococo runtimes has been removed in preparation of the runtimes moving to polkadot-fellows/runtimes, but this still needs to be added to xcm-builder, as we have teams waiting to pull the configs from xcm-builder.

@KiChjang
Copy link
Contributor

KiChjang commented Aug 1, 2023

As mentioned in Element, the previous point made by Gav still stands -- the code being introduced here is too opinionated to be in the xcm-builder directory. Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants