This repository has been archived by the owner on Sep 22, 2021. It is now read-only.
Cancel poll vote interaction #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This works definitely well thank a lot for that. There a warning for the href:
Check the Also with 3 votes the percentage look long :) |
Tbaut
suggested changes
May 28, 2020
front-end/src/components/Post/GovernanceSideBar/Referenda/VoteReferendum.tsx
Outdated
Show resolved
Hide resolved
|
As you suggested, added the styling in the Edit:
|
Tbaut
reviewed
May 29, 2020
front-end/src/components/Post/GovernanceSideBar/Referenda/VoteReferendum.tsx
Outdated
Show resolved
Hide resolved
Tbaut
reviewed
May 29, 2020
Tbaut
reviewed
May 29, 2020
|
Sorry, misinterpreted a comment. Api check is back. |
Tbaut
approved these changes
May 30, 2020
niklabh
added a commit
that referenced
this pull request
Jun 2, 2020
* Added vote tables * Added permissions * Added votes post relationship * Added UI * Added Offchain Poll * Everything works * onchain only * removed console * using default address field * removed span * Split useEffect * Using encoded address * && instead of ? * Using use callback * Box shadow * conditional component dispaly * comment * Using enum * Added own vote * Added check of has_poll on create post itself * Added check of has_poll on create post itself * box-shadow fix * Update front-end/src/ui-components/CouncilSignalBar.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * Update front-end/src/components/Post/Poll/CouncilSignals.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * Update front-end/src/ui-components/OffChainSignalBar.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * Adding address of council if it exist * checking defaultAddress not empty string * renamed OffChainSignals -> GeneralSignals * Commented poll * lint * Update front-end/src/ui-components/CouncilSignalBar.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * fix table setup * < 2 check * Signal percentage * Helpertooltip next to title * Update front-end/src/components/Post/Poll/CouncilSignals.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update front-end/src/components/Post/Poll/GeneralSignals.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Added checkbox * fix * Fix ayes nays * Cancel poll vote interaction (#815) * Cancel poll vote interaction * remove apiReady and revert AyeNayButtons * ownVote css styling * space * Use ButtonLink * fix percentage decimal display * api check * use type guard and avoid over fetching * comment out Poll * lint * Added isReferendum Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: erler <mail@michelerler.com> Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> Co-authored-by: thib <thibaut.sardan@gmail.com>
Tbaut
added a commit
that referenced
this pull request
Jun 10, 2020
* Added vote tables * Added permissions * Added votes post relationship * Added UI * Added Offchain Poll * Everything works * onchain only * removed console * using default address field * removed span * Split useEffect * Using encoded address * && instead of ? * Using use callback * Box shadow * conditional component dispaly * comment * Using enum * Added own vote * Added check of has_poll on create post itself * Added check of has_poll on create post itself * box-shadow fix * Update front-end/src/ui-components/CouncilSignalBar.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * Update front-end/src/components/Post/Poll/CouncilSignals.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * Update front-end/src/ui-components/OffChainSignalBar.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * Adding address of council if it exist * checking defaultAddress not empty string * renamed OffChainSignals -> GeneralSignals * Commented poll * lint * Update front-end/src/ui-components/CouncilSignalBar.tsx Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> * fix table setup * Using council members from chain db rather than onchain. Showing old council of poll closing time has passed * < 2 check * Signal percentage * Helpertooltip next to title * Update front-end/src/components/Post/Poll/CouncilSignals.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update front-end/src/components/Post/Poll/GeneralSignals.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Added checkbox * fix * Fix ayes nays * Cancel poll vote interaction (#815) * Cancel poll vote interaction * remove apiReady and revert AyeNayButtons * ownVote css styling * space * Use ButtonLink * fix percentage decimal display * api check * use type guard and avoid over fetching * comment out Poll * lint * changed block_number to poll_block_number_end * extracted reused code in function * Uncommented poll * removed twoWeekBlocks * Calculating end block * fix * Added blocktime context * using hook instead of context for getting block time * not using default 0 * showing error on no block number * Moved poll table * timestamps and permissions * added relationship * added @ardatan/graphql-tools * added permission * removed unused relationship * prevent poll vote when finished (#878) Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: erler <mail@michelerler.com> Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com> Co-authored-by: thib <thibaut.sardan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To indicate whether and how a user has voted on a poll, the respective button mimics
hoverstyle while the other button is disabled. Clicking on the link below cancels the vote.I also tried out keeping both buttons active so that clicking the other option would cancel the previous vote and cast a new one, but that felt a bit unintuitive.