Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Prevent poll vote when passed the end block #878

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Jun 10, 2020

additional to #814 (review)

  • unify current block queries
  • prevent vote when poll ended.
    image

We should have a proper countdown etc soon.

Copy link
Contributor

@niklabh niklabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine

@Tbaut Tbaut merged commit 0d8240a into block-number-check Jun 10, 2020
@Tbaut Tbaut deleted the tbaut-poll branch June 10, 2020 14:27
Tbaut added a commit that referenced this pull request Jun 10, 2020
* Added vote tables

* Added permissions

* Added votes post relationship

* Added UI

* Added Offchain Poll

* Everything works

* onchain only

* removed console

* using default address field

* removed span

* Split useEffect

* Using encoded address

* && instead of ?

* Using use callback

* Box shadow

* conditional component dispaly

* comment

* Using enum

* Added own vote

* Added check of has_poll on create post itself

* Added check of has_poll on create post itself

* box-shadow fix

* Update front-end/src/ui-components/CouncilSignalBar.tsx

Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com>

* Update front-end/src/components/Post/Poll/CouncilSignals.tsx

Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com>

* Update front-end/src/ui-components/OffChainSignalBar.tsx

Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com>

* Adding address of council if it exist

* checking defaultAddress not empty string

* renamed OffChainSignals -> GeneralSignals

* Commented poll

* lint

* Update front-end/src/ui-components/CouncilSignalBar.tsx

Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com>

* fix table setup

* Using council members from chain db rather than onchain. Showing old council of poll closing time has passed

* < 2 check

* Signal percentage

* Helpertooltip next to title

* Update front-end/src/components/Post/Poll/CouncilSignals.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

* Update front-end/src/components/Post/Poll/GeneralSignals.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>

* Added checkbox

* fix

* Fix ayes nays

* Cancel poll vote interaction (#815)

* Cancel poll vote interaction

* remove apiReady and revert AyeNayButtons

* ownVote css styling

* space

* Use ButtonLink

* fix percentage decimal display

* api check

* use type guard and avoid over fetching

* comment out Poll

* lint

* changed block_number to poll_block_number_end

* extracted reused code in function

* Uncommented poll

* removed twoWeekBlocks

* Calculating end block

* fix

* Added blocktime context

* using hook instead of context for getting block time

* not using default 0

* showing error on no block number

* Moved poll table

* timestamps and permissions

* added relationship

* added @ardatan/graphql-tools

* added permission

* removed unused relationship

* prevent poll vote when finished (#878)

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: erler <mail@michelerler.com>
Co-authored-by: Michel Erler <7072141+erler@users.noreply.github.com>
Co-authored-by: thib <thibaut.sardan@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants