[solidity,llvm-context] Improve support for debugging the compiler #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xermicus
reviewed
Aug 23, 2024
crates/solidity/src/process/mod.rs
Outdated
| .expect("Error reading from input file"); | ||
| } | ||
| None => { | ||
| stdin.read_to_end(&mut buffer).expect("Stdin reading error"); |
crates/solidity/src/process/mod.rs
Outdated
| match input_file { | ||
| Some(ins) => { | ||
| ins.read_to_end(&mut buffer) | ||
| .expect("Error reading from input file"); |
There was a problem hiding this comment.
Nit: We usually unwrap results in case we are guaranteed to never panic (the rust compiler can not now) and use expect(...) to explain the reason as to why the unwrap would never panic.
But since the this function does already return a anhow::Result it seems like here we can be just bubble up the error instead?
crates/solidity/src/process/mod.rs
Outdated
| @@ -74,6 +82,11 @@ pub fn call(input: Input) -> anyhow::Result<Output> { | |||
| anyhow::anyhow!("{:?} subprocess spawning error: {:?}", executable, error) | |||
| })?; | |||
|
|
|||
| #[cfg(debug_assertions)] | |||
| if let Some(dbg_config) = &input.debug_config { | |||
| let _ = dbg_config.dump_stage_output(&input.contract.path, Some("stage"), &input_json); | |||
There was a problem hiding this comment.
Is silently swallowing the error here intended? Intuitively should either bubble up or panic here?
wpt967
force-pushed
the
debugger-support
branch
from
e0adf97
to
e2271fd
Compare
xermicus
reviewed
Aug 23, 2024
crates/solidity/src/process/mod.rs
Outdated
| executable, | ||
| error, | ||
| ) | ||
| }); |
wpt967
force-pushed
the
debugger-support
branch
from
e2271fd
to
2e77b70
Compare
xermicus
reviewed
Aug 23, 2024
crates/solidity/src/process/mod.rs
Outdated
| .read_to_end(&mut buffer) | ||
| .map_err(|error| -> anyhow::Result<()> { | ||
| anyhow::bail!("Failed to read recursive process input file: {:?}", error); | ||
| }); |
crates/solidity/src/process/mod.rs
Outdated
| "Failed to read recursive process input from stdin: {:?}", | ||
| error | ||
| ); | ||
| }); |
Add option --recursive-process-input <filename> for use with --recursive-process to specify the name of a file to use instead of reading from stdin. If --debug-output-dir is set, dump the file passed to the recursive invocation of the compiler as a JSON file suitable for use with --recursive-process-input. These changes are intended to support debugging the compiler and are only available with DEBUG builds.
wpt967
force-pushed
the
debugger-support
branch
from
2e77b70
to
b29381a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option --recursive-process-input for use with --recursive-process to specify the name of a file to use instead of reading from stdin.
If --debug-output-dir is set, dump the file passed to the recursive invocation of the compiler as a JSON file suitable for use with --recursive-process-input.
These changes are intended to support debugging the compiler and are only available with DEBUG builds.