Review get-substrate.sh Script

[danforbes]

According to @bkchr, the get-substrate.sh script is likely very out-of-date. It may be worth reevaluating its value and soundness. For starters, notice that the following line installs git twice:
https://github.com/paritytech/scripts/blob/master/get-substrate.sh#L35

[danforbes]

See here for more discussion paritytech/polkadot#1479

[riusricardo]

According to @bkchr, the get-substrate.sh script is likely very out-of-date. It may be worth reevaluating its value and soundness. For starters, notice that the following line installs git twice:
https://github.com/paritytech/scripts/blob/master/get-substrate.sh#L35

I remember that some VMs don't have git as default deployment. This is why it is part of the packages, it won't do a thing if it is already installed.

EDIT: I see that it is twice 🤦

[riusricardo]

I agree with @bkchr, we should deprecate the script.

[danforbes]

Ricardo, other than Knowledge Base, Tutorials, Recipes and Node Template do we reference this script anywhere?

[danforbes]

I checked on the Polkadot Wiki and didn't see it there but admittedly I didn't look too hard.

[danforbes]

@joepetrowski do you know of any other places where the get-substrate.sh script may appear?

[riusricardo]

We should keep it in the repo and fix it but stop referencing and encouraging it. IMO, we don't want to break workshops/videos that used this method.

[thiolliere]

when latest rust nightly breaks substrate this script will fail, when this happens some ppl have no clue how to go from it.

At least when case cargo build fails, we should print a message pointing to some url which explains the complete process to install substrate.

(Also we could improve by setting a specific nightly toolchain but then we should make some CI to be sure this nightly doesn't get too old, but I would rather deprecate with some more message for ppl stuck)

[TriplEight]

FWIW it makes sense to test this script nightly in CI.
And btw, why it's still here and not in the substrate repo?

[riusricardo]

And btw, why it's still here and not in the substrate repo?

@TriplEight We are deprecating the script. @thiolliere suggestions are good and we should print information stating this and where they should find the latest installation instructions.

[nuke-web3]

I have #253 opened for those interested in updating/improving/expanding 🤞🏼 this script

[rcny]

Closing as stale.