Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug_assertions whenever calling queue_notification #3056

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add debug_assertions whenever calling queue_notification #3056

merged 2 commits into from
Nov 30, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 30, 2022

Provides more clarity about the problem if queue_notification panics.

mergify[bot]
mergify bot approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2022 •
edited
Loading

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Nov 30, 2022
@mergify mergify bot merged commit bc4ec47 into paritytech:main Nov 30, 2022
@tomaka tomaka deleted the debug-assert-queue-notif branch November 30, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tomaka