Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version package.json from Cargo.toml (via script) #33

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Oct 29, 2021

Adds scripts/js/align_version.mjs that does the following -

  1. reads the Cargo.toml
  2. adjust the package.json version with the version from step 1

It is executed via npm run alignVersion. At this point it is done manually, but in a perfect world, should just be done on CI and pushed back to the repo (when there are changes) to remove all manual steps. And then for extra bonus points publish to the npmjs registry.,

Additionally, the PR also adds -

  • an updated .gitignore to skip the node_modules folder
  • a package-lock.json generated from npm install
  • bumped version in package.json from running the added command

@bkchr bkchr merged commit ac3925f into main Oct 29, 2021
@bkchr bkchr deleted the jg-align-version branch October 29, 2021 10:07
@jacogr jacogr mentioned this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants