Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use local version of wasm-pack #1168

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: use local version of wasm-pack #1168

merged 1 commit into from
Dec 20, 2022

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Dec 19, 2022

so we can build:calc without having wasm-pack installed globally

@xlc xlc requested a review from a team as a code owner December 19, 2022 22:53
@TarikGul TarikGul changed the title use local version of wasm-pack fix: use local version of wasm-pack Dec 20, 2022
TarikGul
TarikGul approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks so much for the contribution. This is a nice QOL change, and good way to have consistency.

@TarikGul TarikGul merged commit f922247 into paritytech:master Dec 20, 2022
@xlc xlc deleted the wasm-pack branch December 20, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshacb marshacb marshacb approved these changes

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xlc @marshacb @TarikGul