Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps)!: update polkadot-js, and adjust for breaking changes (isFrozen compatibility fix) & kusama test removed #1285

Merged
merged 1 commit into from
May 26, 2023

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented May 25, 2023

Breaking Changes

This PR updates the dependencies but also introduces some breaking changes. Below a detailed description of the changes :

Update Deps

It updates the following deps:

"@polkadot/api": "^10.7.2",
"@polkadot/api-contract": "^10.7.2",
"@polkadot/util-crypto": "^12.2.1",

isFrozen field fix - Breaking Change

After updating the dependencies, there was this error when trying to build :

src/services/accounts/AccountsAssetsService.ts:186:30 - error TS2339: Property 'isFrozen' does not exist on type 'PalletAssetsAssetAccount'.

186       isFrozen: balanceProps.isFrozen,
                                 ~~~~~~~~
Found 1 error in src/services/accounts/AccountsAssetsService.ts:186

so the code of isFrozen was updated to support both past & future runtimes.

Kusama test removed

While running the latest-e2e-tests, one test of Kusama was failing with this error message
2023-05-26 00:14:36 error: "17" was not recognized as a queryable pallet.

So after checking :

it looks like the pallet with index 17 was removed so the test that was checking the errors endpoint of pallet 17 was also removed.

Docs updated

  • Updated docs related to the isFrozen change & built docs again.

- Updated pjs api deps.
- Updated code of `isFrozen` so that we support both past & future runtimes.
- Removed one test from latest-e2e-tests of kusama because this pallet was removed.
- Updated docs related to the `isFrozen` change.
@Imod7 Imod7 requested a review from a team as a code owner May 25, 2023 22:37
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TarikGul TarikGul changed the title fix(deps): update pjs api, isFrozen compatibility fix & kusama test removed fix(deps)!: update pjs api, isFrozen compatibility fix & kusama test removed May 26, 2023
@Imod7 Imod7 changed the title fix(deps)!: update pjs api, isFrozen compatibility fix & kusama test removed fix(deps)!: update pjs api, isFrozen compatibility fix (adjust for breaking changes) & kusama test removed May 26, 2023
@Imod7 Imod7 changed the title fix(deps)!: update pjs api, isFrozen compatibility fix (adjust for breaking changes) & kusama test removed fix(deps)!: update polkadot-js, and adjust for breaking changes (isFrozen compatibility fix) & kusama test removed May 26, 2023
@Imod7 Imod7 merged commit 110b01a into master May 26, 2023
13 checks passed
@Imod7 Imod7 deleted the domi-update-pjs branch May 26, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants