Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add weight for Dock mainnet #511

Merged
merged 2 commits into from Apr 9, 2021
Merged

Conversation

lovesh
Copy link
Contributor

@lovesh lovesh commented Apr 8, 2021

Signed-off-by: lovesh lovesh.bond@gmail.com

Signed-off-by: lovesh <lovesh.bond@gmail.com>
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TarikGul TarikGul requested a review from emostov April 8, 2021 15:01
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @lovesh would you like to make sure fee calcs are enabled on the test net as well? You could just changes the null to 1 here:

And then the block weight store would still be able to be dynamically built up as the querys are made.

@emostov emostov linked an issue Apr 8, 2021 that may be closed by this pull request
@emostov emostov changed the title Add weight for Dock mainnet feat: Add weight for Dock mainnet Apr 8, 2021
Signed-off-by: lovesh <lovesh.bond@gmail.com>
@lovesh
Copy link
Contributor Author

lovesh commented Apr 9, 2021

@emostov Done. Thanks.

@emostov emostov merged commit 7b7451d into paritytech:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docknetwork Fee calculation not supported for this network
3 participants