fix: update accounts balance-info and vesting-info to use historicApi #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
requested review from
dvdplm,
niklasad1,
maciejhirsz,
insipx and
jsdw
10 tasks
niklasad1
approved these changes
Oct 18, 2021
dvdplm
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds e2e-tests for vesting-info, and updates both
AccountsBalanceServiceandAccountsVestingInfoServiceto both use the historicApi.rel: #698
As a follow up to [#717] I added an error message when vesting-info is queried on a runtime where it doesn't exist.