Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support calamari parachain fee calculations #749

Merged
merged 10 commits into from
Nov 4, 2021

Conversation

grenade
Copy link
Contributor

@grenade grenade commented Nov 4, 2021

No description provided.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 4, 2021

User @grenade, please sign the CLA here.

@TarikGul
Copy link
Member

TarikGul commented Nov 4, 2021

Hey @grenade thanks for the PR. I'll have a run at this soon, just to verify, but from a quick glance it looks good. Youll just have to run build.sh file inside of /<ROOT>/calc

@grenade
Copy link
Contributor Author

grenade commented Nov 4, 2021

Hey @grenade thanks for the PR. I'll have a run at this soon, just to verify, but from a quick glance it looks good. Youll just have to run build.sh file inside of /<ROOT>/calc

thank you! i've actually not been able to prove this works yet (hence the draft pr).
https://api.serrano.calamari.systems/blocks/311056 is running the version of code in this pr but still shows "Fee calculation not supported for this network" so i'm still trying to work out why the fee calculation doesn't appear to work.

@TarikGul
Copy link
Member

TarikGul commented Nov 4, 2021

Is there a public node I can test this against?

@grenade
Copy link
Contributor Author

grenade commented Nov 4, 2021

Is there a public node I can test this against?

yes. any of:

  • wss://chilli.calamari.systems
  • wss://falafel.calamari.systems
  • wss://fritti.calamari.systems
  • wss://smoothie.calamari.systems
  • wss://jalapeno.calamari.systems

@TarikGul
Copy link
Member

TarikGul commented Nov 4, 2021

Could you provide me with a block number/hash that contains an extrinisic that would require a fee as well?
Feel free to run yarn lint --fix for the linter as well

@TarikGul
Copy link
Member

TarikGul commented Nov 4, 2021

nvm found a block.

@grenade grenade marked this pull request as ready for review November 4, 2021 16:51
calc/pkg/package.json Outdated Show resolved Hide resolved
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TarikGul TarikGul changed the title support calamari parachain fee calculations fix: support calamari parachain fee calculations Nov 4, 2021
@TarikGul
Copy link
Member

TarikGul commented Nov 4, 2021

After the tests, I will merge. Just as a heads up these changes will be reflected in next weeks release.

@TarikGul TarikGul merged commit 1e2f4a5 into paritytech:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants