Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add leaseOffset to leasesCurrent end calc #801

Merged
merged 2 commits into from
Dec 24, 2021
Merged

fix: add leaseOffset to leasesCurrent end calc #801

merged 2 commits into from
Dec 24, 2021

Conversation

sawvox
Copy link
Contributor

@sawvox sawvox commented Dec 22, 2021

Currently the endOfLeasePeriod calculation is missing the leaseOffset being added to it

@sawvox sawvox requested a review from a team as a code owner December 22, 2021 21:50
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Dec 22, 2021

User @sawvox, please sign the CLA here.

TarikGul
TarikGul approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR, and great catch. lgtm

@TarikGul TarikGul requested a review from a team December 23, 2021 13:52
@TarikGul TarikGul merged commit 4d83dcb into paritytech:master Dec 24, 2021
@sawvox sawvox deleted the sawvox-patch-leasesCurrent branch January 3, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emostov emostov emostov approved these changes

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sawvox @emostov @TarikGul