Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support fee calculation for Bifrost #853

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Conversation

ark930
Copy link
Contributor

@ark930 ark930 commented Feb 28, 2022

No description provided.

@ark930 ark930 requested a review from a team as a code owner February 28, 2022 08:10
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 28, 2022

User @ark930, please sign the CLA here.

@TarikGul
Copy link
Member

Looks like it needs a yarn lint --fix

@ark930
Copy link
Contributor Author

ark930 commented Mar 1, 2022

@TarikGul My mistake, already fixed.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TarikGul My mistake, already fixed.

No Worries at all :)

lgtm!

@emostov
Copy link
Contributor

emostov commented Mar 1, 2022

@TarikGul - should we have a CI job that generates calc/pkg/calc_bg.wasm to make sure its inline with exactly what gets merged?

@TarikGul
Copy link
Member

TarikGul commented Mar 1, 2022

@TarikGul - should we have a CI job that generates calc/pkg/calc_bg.wasm to make sure its inline with exactly what gets merged?

Yea I was just thinking the same thing since I always recompile it after these PR's are merged. I agree though, it would enforce consistency on the build.

@TarikGul TarikGul merged commit cd33db7 into paritytech:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants