fix(deps): update pjs api #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
approved these changes
Apr 26, 2022
|
As clarification I used this PR to update the versions again because this didnt go in last week: Updated versions are as follows: |
|
I also updated one mock test variable that was actually technically incorrect. But Polkadot-js has added stricter requirements for hash length, so it caught it, and I just made sure it was the correct byte length. |
TarikGul
commented
May 2, 2022
| @@ -27,4 +27,4 @@ export const MAX_H512 = | |||
| '0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff'; | |||
| export const MAX_H256 = | |||
| '0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff'; | |||
| export const MAX_H160 = '0xffffffffffffffffffffffffffffffffffffffffffffffff'; | |||
| export const MAX_H160 = '0xffffffffffffffffffffffffffffffffffffffff'; | |||
There was a problem hiding this comment.
This just changes the byte length from 24 -> 20 as that is required for a H160 type and polkadot-js util will no longer shorten the length for you but error with an assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following deps: