Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poc add zombienet #668

Closed
wants to merge 51 commits into from
Closed

Conversation

pepoviola
Copy link
Contributor

Hi @wirednkod, I open this as draft to check how we can integrate the test you need in zombienet. At the moment I switch to use native provider in the ci since podman just hungs spawning the pods.
If you have test that needs the chain-spec file and the endpoints of the nodes, we can add those to the feature file and will run inside the test-runner.

Thanks!

@tomaka
Copy link
Contributor

tomaka commented Jan 21, 2022

For context, it's not the Polkadot nodes that we want to test. We want to test whether substrate-connect successfully synchronizes with the chain that the Polkadot nodes are running.

@wirednkod
Copy link
Contributor

wirednkod commented Jan 21, 2022

Thank you @pepoviola . I will create a simple test for implementing what @tomaka describes and use the code of PR for testing purposes if you are ok with that.

If you have test that needs the chain-spec file and the endpoints of the nodes, we can add those to the feature file and will run inside the test-runner.

For that test the chainspecs (which should contain the spawned bootnodes) will be needed - I will check the repo of zombienet to figure out how to do this.

@pepoviola
Copy link
Contributor Author

Thanks for the feedback @tomaka / @wirednkod, I use polkadot and the base smoke test from zombienet just to check how to integrate zombienet in GH Actions. @wirednkod ping me to work in your test case 👍

Thanks!

.zombienet-tests/0001-custom.js Outdated Show resolved Hide resolved
.zombienet-tests/0001-custom.js Outdated Show resolved Hide resolved
.zombienet-tests/0001-custom.js Outdated Show resolved Hide resolved
@pepoviola pepoviola closed this Jan 21, 2022
@pepoviola pepoviola reopened this Jan 22, 2022
@wirednkod wirednkod mentioned this pull request Feb 2, 2022
@wirednkod wirednkod added this to In progress in V1 Launch via automation Feb 2, 2022
Comment on lines +16 to +17
// add 20s sleep to give time to sync
await new Promise((resolve) => setTimeout(resolve, 20000))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a slight timeout for pausing the process until Chain is initialised.
If this timeout is removed then the following error shows:

2022-02-03 17:22:25        RPC-CORE: subscribeNewHeads(): Header:: Chain is not initialised
2022-02-03 17:22:25             DRR: Chain is not initialised
2022-02-03 17:22:25        RPC-CORE: subscribeNewHeads(): Header:: Chain is not initialised
unhandledRejection
Error: Chain is not initialised

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the sleep x command in the feature file instead of having in this scripts.

@wirednkod
Copy link
Contributor

A new PR is addressing this.

@wirednkod wirednkod closed this Feb 4, 2022
V1 Launch automation moved this from In progress to Done Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants