-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zombienet integration tests #706
Conversation
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Hi @wirednkod, I updated the version of zombienet and the Thanks! |
I suppose that the numbers, such as |
Hi @tomaka/@wirednkod , I will clean the naming here and try to remove the |
.zombienet-tests/utils.js
Outdated
const { ApiPromise } = require("@polkadot/api") | ||
|
||
async function connect(nodeName, networkInfo, isParachain) { | ||
const { userDefinedTypes } = networkInfo.nodesByName[nodeName] | ||
const customChainSpec = require(networkInfo.chainSpecPath) | ||
const { createPolkadotJsScClient } = await import("@substrate/connect") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to mix require
and import
here. Maybe decide on which one?
.zombienet-tests/0002-placeholder.js
Outdated
@@ -0,0 +1,17 @@ | |||
const { connect } = require("./utils") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe name the file 0002-checkSync.js
or something, and not placeholder
?
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Would be good to merge for me after my two comments (provided it works obviously) |
* change branch name * change collators config * add debug * bumo zombienet version * fmt * use main branch * remove debug
Hi @tomaka, can you give me some hints on this error:
We launch a relay-chain with 2 validator and a parachain with 2 collator:
Thanks!! |
As always, I need debug logs. |
It seems that smoldot can't connect to the peer-to-peer network of the parachain, but also doesn't even try to connect. Are you sure that there are bootnodes in the parachain spec? |
Thanks for the feedback @tomaka I checked the logs and there is a 2022-03-11T09:25:00.0891526Z ⚙ Added Boot Nodes: /ip4/127.0.0.1/tcp/37227/ws/p2p/12D3KooWLj7rSyPHpVp4zBf8S9nu7LM5eep8iFpWT8eMKgrrNF29
|
Sorry, didn't realize that the search in GitHub's logs viewer stops after 100 lines without even telling you. 😮💨 |
The problem is that you're passing |
This PR replaces the one that @pepoviola opened before - mainly for keeping the history clean