Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update deps #122

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore(deps): update deps #122

merged 1 commit into from
Jun 5, 2024

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented May 31, 2024

Description

Updated the following dependencies to new patch versions:

  • @types/jest
  • rimraf
  • ts-jest

Updated the following dependencies to new minor versions:

  • @babel/plugin-transform-modules-commonjs
  • eslint-config-prettier
  • eslint-plugin-prettier
  • prettier
  • typescript
  • eslint to v8.57.0

Updated the following dependencies to new major versions:

  • eslint-plugin-simple-import-sort
  • @typescript-eslint/eslint-plugin to ^7.11.0
  • @typescript-eslint/parser to ^7.11.0

⚠️ Breaking Changes

The upgrade of

  • @typescript-eslint/eslint-plugin to ^7.11.0 and
  • @typescript-eslint/parser to ^7.11.0

have the following breaking changes

  1. Update Node.js engine requirement to ^18.18.0 || >=20.0.0. This means we are dropping support for Node 16, 19, and Node 18 versions prior to 18.18.0. Note that this is the same requirement that ESLint v9 will impose.
  2. Update the TypeScript peer dependency requirement to >=4.7.4.
  3. Update the ESLint peer dependency requirement to ^8.56.0.

mentioned v7.0.0 and Announcing typescript-eslint v7

⚠️ Important Note

The package eslint was updated to v8.57.0 even though v9.3.0 is available. This is because v9.0.0 introduces major breaking changes that require complete refactoring of the eslint config files, their syntax and the @typescript-eslint packages . These changes will impact not only the current repository but also the repositories that depend on it.
Hence, this refactoring should be addressed in a separate PR.

Some related resources that show the extend of the required changes :

Having said that, a configuration migrator was announced just today (announcement) that will hopefully streamline the migration process.

Tested

The current dependencies update were tested with Sidecar.

Changelog

Next release that includes this PR should mention the breaking changes resulting from the update of the @typescript-eslint packages.

Copy link

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Imod7 Imod7 merged commit 58fe47c into main Jun 5, 2024
4 checks passed
@Imod7 Imod7 deleted the domi-update-deps branch June 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants