Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Substrate on Windows #1343

Closed
9 tasks done
Mischi opened this issue Jan 2, 2019 · 5 comments
Closed
9 tasks done

Substrate on Windows #1343

Mischi opened this issue Jan 2, 2019 · 5 comments
Labels
J0-enhancement An additional feature request.
Milestone

Comments

@Mischi
Copy link
Contributor

Mischi commented Jan 2, 2019

Hi. In this issue, I wanna track the progress of all Windows related TODOs. Goal is to make Substrate as easy to develop as on MacOS / Linux 😄

TODOs:

I've created https://github.com/Mischi/substrate/tree/fix-windows which contains updates to parity-crypto, rocksdb, ring, and untrusted. The branch works now on three windows machines. (CC: @kenhuang)

Next I'll have a look on updating libp2p ....

@rphmeier rphmeier added the J0-enhancement An additional feature request. label Jan 7, 2019
@tomaka
Copy link
Contributor

tomaka commented Jan 7, 2019

Next I'll have a look on updating libp2p ....

This is a non-trivial task, but we can easily crate a side-branch in libp2p with ring updated to 0.13 if that's the blocking point.

@Mischi
Copy link
Contributor Author

Mischi commented Jan 7, 2019

@tomaka, Indeed. it is a non-trivial task for me atm. and it will take me some time to work through libp2p and how/what substrate uses of it.

Regarding a side-branch, this is what I did in Mischi/rust-libp2p@f78f6ec and Mischi@052710c and it is working for me and my coworkers.

If you're ok with using a side-branch for the moment than it would definitly make life easier for some Windows users for the time being 😃

@tomaka, do you wanna push the branch https://github.com/Mischi/rust-libp2p/tree/fix-windows to https://github.com/libp2p/rust-libp2p? I could create a pull request then for substrate if needed.

Thanks!

@tomaka
Copy link
Contributor

tomaka commented Jan 7, 2019

Indeed. it is a non-trivial task for me atm. and it will take me some time to work through libp2p and how/what substrate uses of it.

I'm already working on it.

@tomaka
Copy link
Contributor

tomaka commented Jan 10, 2019

cc #1386

@Mischi
Copy link
Contributor Author

Mischi commented Jan 14, 2019

Substrate is now working for us on Windows without any problems. Thanks everybody!

@Mischi Mischi closed this as completed Jan 14, 2019
liuchengxu pushed a commit to liuchengxu/substrate that referenced this issue May 31, 2023
If the block number relayer is trying to relay is beyond pruning depth, then relayer fails to generate the core domain proof using system domain state since the state root and receipt is already pruned. This change will always check and skip block if beyond pruning depth.

For system domain, this change do not apply since we can always generate proof from the state.

Closes: paritytech#1343
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

4 participants