Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Parameterise locked stake everywhere + Lock for all WithdrawReasons #3564

Closed
kianenigma opened this issue Sep 6, 2019 · 0 comments · Fixed by #3606
Closed

Parameterise locked stake everywhere + Lock for all WithdrawReasons #3564

kianenigma opened this issue Sep 6, 2019 · 0 comments · Fixed by #3606
Labels
J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Sep 6, 2019 •
edited
Loading

#3364 (comment)

election-phragmen is already fixed.
election needs to allow a value parameter with vote and then be reverted.
staking needs to be reverted.

Henceforth and generally speaking, for the reason mentioned in the link above, substrate will NOT make any exceptions for paying tx fees when locking an account. It is the responsibility of the user + help of the UI to warn them that they should not lock up everything.

Once done, also bring back the WithdrawReason to ::all().

cc @jacogr @joepetrowski
@kianenigma kianenigma added the J0-enhancement An additional feature request. label Sep 6, 2019
@kianenigma kianenigma changed the title Parameterise locked stake everywhere Parameterise locked stake everywhere + Lock for all WithdrawReasons Sep 9, 2019
@kianenigma kianenigma modified the milestone: 1.x series Sep 9, 2019
@kianenigma kianenigma added the Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. label Sep 9, 2019
@kianenigma kianenigma mentioned this issue Sep 12, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Staking and Democracy locking paritytech/substrate
1 participant
@kianenigma