This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix Staking and Democracy locking #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
commented
Sep 12, 2019
| } | ||
|
|
||
| #[test] | ||
| fn voting_cannot_lock_less_than_limit() { |
There was a problem hiding this comment.
this + the following two are the main tests which are related to this PR, this rest of this file is almost the same with some minor style changes.
gavofyork
reviewed
Sep 12, 2019
| /// | ||
| /// Furthermore, each vector of scalars is chunked with the cap of `APPROVAL_SET_SIZE`. | ||
|
|
||
| // A list of votes for each voter. The votes are stored as numeric values and parsed in a |
There was a problem hiding this comment.
why replace the doc-comment as a dumb-comment?
There was a problem hiding this comment.
Ahh, I started using this plugin to wrap doc-comment lines and... it seems to have failed me here.
There was a problem hiding this comment.
(probably because it inferred the prefix from the line above it "// ---- persistent state (always relevant, changes constantly)" )
gavofyork
approved these changes
Sep 12, 2019
|
needs a runtime bump |
svyatonik
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Fix locking. * Some reformattings. * Fix build. * Fix doc comment. * Bump.
Demi-Marie
pushed a commit
to Demi-Marie/substrate
that referenced
this pull request
Sep 17, 2019
* Fix locking. * Some reformattings. * Fix build. * Fix doc comment. * Bump.
en
pushed a commit
to en/substrate
that referenced
this pull request
Sep 24, 2019
* Fix locking. * Some reformattings. * Fix build. * Fix doc comment. * Bump.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
election::vote()to define how much stake should be locked with the vote (with a configurable minimum)fn chunking_xxx(): everything about the vectors being chunked.fn voting_xxx(): everything about voting rules.fn candidacy_xxx(): everything about candidacy rules.fn election_xxx(): e2e tests about election rounds carry etc.fn pot_xxx(): everything about the weighted, decaying vote pot, which maybe we should have named differently.closes #3564
TODO: make a PR for polkadot once
MinimumVotingLockis settled.