-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
/benchmark runtime pallet pallet_contracts |
1 similar comment
/benchmark runtime pallet pallet_contracts |
Benchmark Runtime Pallet for branch "at-fix-instantiate-benchmark" with command cargo run --quiet --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Results
|
… at-fix-instantiate-benchmark
…path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
.saturating_add((2_096_000 as Weight).saturating_mul(s as Weight)) | ||
(420_314_000 as Weight) | ||
// Standard Error: 132_000 | ||
.saturating_add((170_494_000 as Weight).saturating_mul(c as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected this to do down to 70us so that it matches the cost of instrument
. My new suspicion is that loading the code into wasmi is responsible for the weight discrepancy.
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
The time for executing the big benchmark contract was included in the component
c
which is only meant to include the instrument cost. Execution cost is charged separately via gas meter. We make sure to return early from the contract to make sure that it is independent ofc
.Once we switch to wasmer we probably need a smarter solution.