Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

bench/cli: extend --extrinsic name filtering #10677

Merged
merged 3 commits into from
Jan 18, 2022
Merged

bench/cli: extend --extrinsic name filtering #10677

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc7612
implement benchmarking multiple extrinsics
dharjeezy Jan 16, 2022
fd1524a
ran cargo +nightly fmt
dharjeezy Jan 16, 2022
ec7f692
remove contains check and made it an equals check
dharjeezy Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions utils/frame/benchmarking-cli/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ impl BenchmarkCmd {
let pallet = self.pallet.clone().unwrap_or_else(|| String::new());
let pallet = pallet.as_bytes();
let extrinsic = self.extrinsic.clone().unwrap_or_else(|| String::new());
let extrinsic = extrinsic.as_bytes();
let extrinsic_split: Vec<&str> = extrinsic.split(',').collect();
let extrinsics: Vec<_> = extrinsic_split.iter().map(|x| x.trim().as_bytes()).collect();

let genesis_storage = spec.build_storage()?;
let mut changes = Default::default();
Expand Down Expand Up @@ -176,7 +177,10 @@ impl BenchmarkCmd {
.filter(|item| pallet.is_empty() || pallet == &b"*"[..] || pallet == &item.pallet[..])
.for_each(|item| {
for benchmark in &item.benchmarks {
if extrinsic.is_empty() || extrinsic == &b"*"[..] || extrinsic == benchmark.name
let benchmark_name = &benchmark.name;
if extrinsic.is_empty() ||
extrinsic.as_bytes() == &b"*"[..] ||
extrinsics.contains(&&benchmark_name[..])
{
benchmarks_to_run.push((
item.pallet.clone(),
Expand Down