Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update Node Template #10710

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Conversation

nuke-web3
Copy link
Contributor

@nuke-web3 nuke-web3 commented Jan 20, 2022

Update Node Template README.md and rust install instructions from docs
4.0.0-dev version for templates

downstream: substrate-developer-hub/substrate-node-template#300

template version = 4.0.0-dev
rust setup updated
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 20, 2022
@nuke-web3 nuke-web3 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I6-documentation Documentation needs fixing, improving or augmenting. and removed A0-please_review Pull request needs code review. labels Jan 20, 2022
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
bin/node-template/docs/rust-setup.md Outdated Show resolved Hide resolved
bin/node-template/docs/rust-setup.md Outdated Show resolved Hide resolved
bin/node-template/docs/rust-setup.md Outdated Show resolved Hide resolved
@nuke-web3
Copy link
Contributor Author

Cannot merge this, I do want to have someone double check me on there being no issue in bumping the version of the crates here to 4.0.0-dev . the rest is no code changes

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: Approval criteria was not satisfied in #10710.

The following errors might have affected the outcome of this attempt:

Merge failed. Check out the criteria for merge. If you're not meeting the approval count, check if the approvers are team members of substrateteamleads or core-devs.

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 71baca7 into master Jan 26, 2022
@paritytech-processbot paritytech-processbot bot deleted the ds/update-template-downstream branch January 26, 2022 22:47
Wizdave97 pushed a commit to ComposableFi/substrate that referenced this pull request Feb 4, 2022
* update node template from downsteam
template version = 4.0.0-dev
rust setup updated

* Update bin/node-template/runtime/Cargo.toml

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>

* Review Rust setup README

* Apply suggestions from code review

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Sacha Lansky <sacha@parity.io>
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* update node template from downsteam
template version = 4.0.0-dev
rust setup updated

* Update bin/node-template/runtime/Cargo.toml

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>

* Review Rust setup README

* Apply suggestions from code review

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Sacha Lansky <sacha@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* update node template from downsteam
template version = 4.0.0-dev
rust setup updated

* Update bin/node-template/runtime/Cargo.toml

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>

* Review Rust setup README

* Apply suggestions from code review

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Sacha Lansky <sacha@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit I6-documentation Documentation needs fixing, improving or augmenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants