Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make offences benchmark runnable #10782

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Feb 2, 2022

The pallet_offences benchmarks currently panic. Fixes #10027 until paritytech/polkadot-sdk#394 is done.
The outputs of the benchmarks are currently unused. I will call the benchbot and revert to make sure that they do not panic anymore.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 2, 2022
@ggwpez ggwpez self-assigned this Feb 2, 2022
@ggwpez ggwpez added this to In progress in [OLD] Benchmarking and Weights via automation Feb 2, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Feb 2, 2022

/bench_bot_is_the_best! runtime pallet pallet_offences

@parity-benchapp
Copy link

Starting benchmark for branch: oty-offences-bench (vs master)

Toolchain:
stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Comment will be updated.

Parity Bot and others added 2 commits February 2, 2022 16:37
…--manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_offences --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/offences/src/weights.rs --template=./.maintain/frame-weight-template.hbs
This reverts commit 73d0cb2.
@ggwpez ggwpez marked this pull request as ready for review February 3, 2022 10:11
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Feb 3, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Feb 4, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 4f672d4 into master Feb 4, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-offences-bench branch February 4, 2022 12:03
[OLD] Benchmarking and Weights automation moved this from In progress to Done Feb 4, 2022
@lemarier
Copy link

lemarier commented Feb 4, 2022

Thanks, guys!

@shawntabrizi shawntabrizi moved this from Done to Archive in [OLD] Benchmarking and Weights Mar 3, 2022
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* Make offences benchmark runnable

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_offences --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/offences/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Revert bench-bot

This reverts commit 73d0cb2.

Co-authored-by: Parity Bot <admin@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Make offences benchmark runnable

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* cargo run --quiet --profile=production  --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_offences --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/offences/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Revert bench-bot

This reverts commit 73d0cb2.

Co-authored-by: Parity Bot <admin@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Development

Successfully merging this pull request may close these issues.

broken benchmark for pallet_offences (report_offence_im_online)
4 participants