This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
update_roles for nomination pools
#11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
github-actions
bot
added
A0-please_review
kianenigma
added
B0-silent
|
/benchmark runtime pallet pallet-nomination-pools |
|
Benchmark Runtime Pallet for branch "kiz-fix-unbond-reward-payout" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet-nomination-pools --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame//src/weights.rs --template=./.maintain/frame-weight-template.hbs Toolchain: stable-x86_64-unknown-linux-gnu (default) ResultsERROR: Unable to commit file ./frame//src/weights.rs |
…-unbond-reward-payout
|
/benchmark runtime pallet pallet-nomination-pools |
|
Benchmark Runtime Pallet for branch "kiz-fix-unbond-reward-payout" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet-nomination-pools --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame//src/weights.rs --template=./.maintain/frame-weight-template.hbs Toolchain: stable-x86_64-unknown-linux-gnu (default) ResultsERROR: Unable to commit file ./frame//src/weights.rs |
|
@athei do you know why this is failing? #11373 (comment) update: seems rust-verison related. |
Yes. Rust versions needs to be updated. |
shawntabrizi
approved these changes
May 9, 2022
|
/benchmark runtime pallet pallet-nomination-pools |
|
Benchmark Runtime Pallet for branch "kiz-fix-unbond-reward-payout" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet-nomination-pools --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame//src/weights.rs --template=./.maintain/frame-weight-template.hbs Toolchain: stable-x86_64-unknown-linux-gnu (default) ResultsERROR: Unable to commit file ./frame//src/weights.rs |
shawntabrizi
reviewed
May 9, 2022
frame/nomination-pools/src/lib.rs
Outdated
Comment on lines
1855
to
1857
| let who = ensure_signed(origin)?; | ||
| let mut bonded_pool = BondedPool::<T>::get(pool_id).ok_or(Error::<T>::PoolNotFound)?; | ||
| ensure!(bonded_pool.roles.root == who, Error::<T>::DoesNotHavePermission); |
There was a problem hiding this comment.
if you can forsee it being useful, could also make this callable by ROOT origin too.
There was a problem hiding this comment.
good point, yeah I think it is.
|
/bench runtime pallet pallet_nomination_pools Somehow it uses the wrong output path: |
|
/benchmark runtime pallet pallet_nomination_pools |
|
Benchmark Runtime Pallet for branch "kiz-fix-unbond-reward-payout" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools Somehow it uses the wrong output path: Somehow it uses the wrong output path: Toolchain: stable-x86_64-unknown-linux-gnu (default) ResultsERROR: Unable to commit file ./frame//src/weights.rs`. |
|
Benchmark Runtime Pallet for branch "kiz-fix-unbond-reward-payout" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs Toolchain: stable-x86_64-unknown-linux-gnu (default) Results |
…--manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
…-unbond-reward-payout
ggwpez
suggested changes
May 10, 2022
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
…substrate into kiz-fix-unbond-reward-payout
ggwpez
reviewed
May 10, 2022
| ) -> DispatchResult { | ||
| let o1 = origin; | ||
| let o2 = o1.clone(); | ||
|
|
||
| let is_pool_root = || -> Result<BondedPool<T>, sp_runtime::DispatchError> { | ||
| let mut bonded_pool = BondedPool::<T>::get(pool_id).ok_or(Error::<T>::PoolNotFound)?; |
There was a problem hiding this comment.
Ahh damn, I think unsigned extrinsics could now cause a DB-Read without paying for it?
There was a problem hiding this comment.
they still pay for the full transaction, as if it set all values.
There was a problem hiding this comment.
not an unsigned message though, since it wouldnt fail the extrinsic test until the origin check
There was a problem hiding this comment.
nit pick fix here #11391
ggwpez
approved these changes
May 10, 2022
|
bot merge |
|
Error: "Check reviews" status is not passing for paritytech/polkadot#5488 |
|
bot merge |
kianenigma
changed the title
update_roles for nomination pools
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* fix a few more things with nomination pools * add bench * use weight fn * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs * allow real root to also set roles * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * move out of the closure * fix a few more things Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* fix a few more things with nomination pools * add bench * use weight fn * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs * allow real root to also set roles * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * move out of the closure * fix a few more things Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* fix a few more things with nomination pools * add bench * use weight fn * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs * allow real root to also set roles * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update frame/nomination-pools/src/lib.rs Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * move out of the closure * fix a few more things Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_rolestransactionpolkadot companion: paritytech/polkadot#5488