Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Revamp nomination pool reward scheme #11669

Merged
merged 93 commits into from
Jul 13, 2022
Merged

Revamp nomination pool reward scheme #11669

merged 93 commits into from
Jul 13, 2022

Commits on May 13, 2022

  1. make pool roles optional

    @kianenigma
    kianenigma committed May 13, 2022
    Configuration menu
    Copy the full SHA
    ea30833 View commit details
    Browse the repository at this point in the history

  2. undo lock file changes?

    @kianenigma
    kianenigma committed May 13, 2022
    Configuration menu
    Copy the full SHA
    00e8c87 View commit details
    Browse the repository at this point in the history

  3. add migration

    @kianenigma
    kianenigma committed May 13, 2022
    Configuration menu
    Copy the full SHA
    fa5e95a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. add the ability for pools to chill themselves

    @kianenigma
    kianenigma committed May 14, 2022
    Configuration menu
    Copy the full SHA
    f2df79e View commit details
    Browse the repository at this point in the history

  2. boilerplate of tests

    @kianenigma
    kianenigma committed May 14, 2022
    Configuration menu
    Copy the full SHA
    56cf997 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. new system works, tests need fixing

    @kianenigma
    kianenigma committed May 15, 2022
    Configuration menu
    Copy the full SHA
    508bc0a View commit details
    Browse the repository at this point in the history

  2. somewhat stable, but I think I found another bug as well

    @kianenigma
    kianenigma committed May 15, 2022
    Configuration menu
    Copy the full SHA
    f83944a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. Fix it all

    @kianenigma
    kianenigma committed May 16, 2022
    Configuration menu
    Copy the full SHA
    ac48c37 View commit details
    Browse the repository at this point in the history

  2. Master.into()

    @kianenigma
    kianenigma committed May 16, 2022
    Configuration menu
    Copy the full SHA
    cbeb9fb View commit details
    Browse the repository at this point in the history

  3. Add more more sophisticated test + capture one more bug.

    @kianenigma
    kianenigma committed May 16, 2022
    Configuration menu
    Copy the full SHA
    031040f View commit details
    Browse the repository at this point in the history

  4. Update frame/staking/src/lib.rs

    @kianenigma
    kianenigma committed May 16, 2022
    Configuration menu
    Copy the full SHA
    efc7b4f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. reduce the diff a little bit

    @kianenigma
    kianenigma committed May 17, 2022
    Configuration menu
    Copy the full SHA
    60d42f1 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. add some test for the slashing bug

    @kianenigma
    kianenigma committed May 19, 2022
    Configuration menu
    Copy the full SHA
    02aa7d4 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @kianenigma
    kianenigma committed May 19, 2022
    Configuration menu
    Copy the full SHA
    90db26e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kiz-pool-chill' of github.com:paritytech/substrate into… 

    … kiz-pool-chill
    @kianenigma
    kianenigma committed May 19, 2022
    Configuration menu
    Copy the full SHA
    5bf6d9c View commit details
    Browse the repository at this point in the history

  4. Master.into()

    @kianenigma
    kianenigma committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1d8c940 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into kiz-poo… 

    …l-chill
    @kianenigma
    kianenigma committed May 20, 2022
    Configuration menu
    Copy the full SHA
    2ec4857 View commit details
    Browse the repository at this point in the history

  2. fix lock file?

    @kianenigma
    kianenigma committed May 20, 2022
    Configuration menu
    Copy the full SHA
    a51e408 View commit details
    Browse the repository at this point in the history

  3. Fix

    @kianenigma
    kianenigma committed May 20, 2022
    Configuration menu
    Copy the full SHA
    28c8852 View commit details
    Browse the repository at this point in the history

  4. fmt

    @kianenigma
    kianenigma committed May 20, 2022
    Configuration menu
    Copy the full SHA
    c9413a2 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into kiz-poo… 

    …l-chill
    @kianenigma
    kianenigma committed May 23, 2022
    Configuration menu
    Copy the full SHA
    433476d View commit details
    Browse the repository at this point in the history

  2. Update frame/nomination-pools/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed May 23, 2022
    Configuration menu
    Copy the full SHA
    c34b655 View commit details
    Browse the repository at this point in the history

  3. Update frame/nomination-pools/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed May 23, 2022
    Configuration menu
    Copy the full SHA
    d0d75a1 View commit details
    Browse the repository at this point in the history

  4. Update frame/nomination-pools/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed May 23, 2022
    Configuration menu
    Copy the full SHA
    a6afb06 View commit details
    Browse the repository at this point in the history

  5. Update frame/nomination-pools/src/mock.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed May 23, 2022
    Configuration menu
    Copy the full SHA
    a3a43e7 View commit details
    Browse the repository at this point in the history

  6. Fix build

    @kianenigma
    kianenigma committed May 23, 2022
    Configuration menu
    Copy the full SHA
    4b7b0c7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'kiz-pool-chill' of github.com:paritytech/substrate into… 

    … kiz-pool-chill
    @kianenigma
    kianenigma committed May 23, 2022
    Configuration menu
    Copy the full SHA
    3f66688 View commit details
    Browse the repository at this point in the history

  8. fix some fishy tests..

    @kianenigma
    kianenigma committed May 23, 2022
    Configuration menu
    Copy the full SHA
    640ec31 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. add one last integrity check for MinCreateBond

    @kianenigma
    kianenigma committed May 24, 2022
    Configuration menu
    Copy the full SHA
    398ddfe View commit details
    Browse the repository at this point in the history

  2. remove bad assertion -- needs to be dealt with later

    @kianenigma
    kianenigma committed May 24, 2022
    Configuration menu
    Copy the full SHA
    d5dc697 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:paritytech/substrate into kiz-poo… 

    …l-chill
    @kianenigma
    kianenigma committed May 24, 2022
    Configuration menu
    Copy the full SHA
    05fb517 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. nits

    @shawntabrizi
    shawntabrizi committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f4dbd0a View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Master.into()

    @kianenigma
    kianenigma committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    0a79c80 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Merge branch 'kiz-pool-chill' of github.com:paritytech/substrate into… 

    … kiz-pool-chill
    @kianenigma
    kianenigma committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    78c0310 View commit details
    Browse the repository at this point in the history

  2. fix tests and add benchmarks for chill

    @kianenigma
    kianenigma committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    0fb1125 View commit details
    Browse the repository at this point in the history

  3. remove stuff

    @kianenigma
    kianenigma committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    12773bb View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. fix benchmarks

    @kianenigma
    kianenigma committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    ca475df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/substrate into… 

    … kiz-pool-chill
    Parity Bot committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    44a2722 View commit details
    Browse the repository at this point in the history

  3. cargo run --quiet --profile=production --features=runtime-benchmarks … 

    …--manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
    Parity Bot committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f027faf View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Master.into()

    @kianenigma
    kianenigma committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    33b581c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'kiz-pool-chill' of github.com:paritytech/substrate into… 

    … kiz-pool-chill
    @kianenigma
    kianenigma committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    c77613f View commit details
    Browse the repository at this point in the history

  3. remove defensive

    @kianenigma
    kianenigma committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    d69af2c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into kiz-poo… 

    …l-chill
    @kianenigma
    kianenigma committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    d318197 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. first working version

    @kianenigma
    kianenigma committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    486a0e9 View commit details
    Browse the repository at this point in the history

  2. Master.into()

    @kianenigma
    kianenigma committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    9b2113f View commit details
    Browse the repository at this point in the history

  3. bring back all tests

    @kianenigma
    kianenigma committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    36cb484 View commit details
    Browse the repository at this point in the history

  4. ALL new tests work now

    @kianenigma
    kianenigma committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    723574b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:paritytech/substrate into kiz-fix… 

    …-reward-pools-2
    @kianenigma
    kianenigma committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    624abe9 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @kianenigma
    kianenigma committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    82287b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. make sure benchmarks and all work

    @kianenigma
    kianenigma committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    e403fb1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/paritytech/substrate into… 

    … kiz-fix-reward-pools-2
    Parity Bot committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4cad93a View commit details
    Browse the repository at this point in the history

  3. cargo run --quiet --profile=production --features=runtime-benchmarks … 

    …--manifest-path=bin/node/cli/Cargo.toml -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=pallet_nomination_pools --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/nomination-pools/src/weights.rs --template=./.maintain/frame-weight-template.hbs
    Parity Bot committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    221369b View commit details
    Browse the repository at this point in the history

  4. round of self-review, make arithmetic safe

    @kianenigma
    kianenigma committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    696a55e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kiz-fix-reward-pools-2' of github.com:paritytech/substr… 

    …ate into kiz-fix-reward-pools-2
    @kianenigma
    kianenigma committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    0689b58 View commit details
    Browse the repository at this point in the history

  6. fix warn

    @kianenigma
    kianenigma committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    bcb413c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. add migration code

    @kianenigma
    kianenigma committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    bce40f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:paritytech/substrate into kiz-fix… 

    …-reward-pools-2
    @kianenigma
    kianenigma committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8fc25ac View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. Fix doc

    @kianenigma
    kianenigma committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    fc3ad18 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge branches 'kiz-fix-reward-pools-2' and 'master' of github.com:pa… 

    …ritytech/substrate into kiz-fix-reward-pools-2
    @kianenigma
    kianenigma committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    03107f3 View commit details
    Browse the repository at this point in the history

  2. add precision notes

    @kianenigma
    kianenigma committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9f875a9 View commit details
    Browse the repository at this point in the history

  3. make arithmetic fallible

    @kianenigma
    kianenigma committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    0513284 View commit details
    Browse the repository at this point in the history

  4. fix node runtime

    @kianenigma
    kianenigma committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    1c43f09 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. a lot of precision tests and notes and stuff

    @kianenigma
    kianenigma committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    ef56db6 View commit details
    Browse the repository at this point in the history

  2. document MaxPOintsToBalance better

    @kianenigma
    kianenigma committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    3da2364 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into kiz-fix… 

    …-reward-pools-2
    @kianenigma
    kianenigma committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    ed5083f View commit details
    Browse the repository at this point in the history

  2. :round of self-review

    @kianenigma
    kianenigma committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    3690489 View commit details
    Browse the repository at this point in the history

  3. fmt

    @kianenigma
    kianenigma committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    62d35c8 View commit details
    Browse the repository at this point in the history

  4. fix some comments

    @kianenigma
    kianenigma committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1c840b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into kiz-fix… 

    …-reward-pools-2
    @kianenigma
    kianenigma committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    7d9d403 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Master.into()

    @kianenigma
    kianenigma committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    78b79f2 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Fix proportional slashing logic

    @kianenigma
    kianenigma committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    a8ccd71 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Update frame/nomination-pools/src/tests.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    60b7641 View commit details
    Browse the repository at this point in the history

  2. Update frame/nomination-pools/src/tests.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    a2082cd View commit details
    Browse the repository at this point in the history

  3. Update frame/nomination-pools/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @kianenigma @ggwpez
    kianenigma and ggwpez committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    ecb7890 View commit details
    Browse the repository at this point in the history

  4. track poinst in migration

    @kianenigma
    kianenigma committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    7e56e1a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kiz-fix-reward-pools-2' of github.com:paritytech/substr… 

    …ate into kiz-fix-reward-pools-2
    @kianenigma
    kianenigma committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    80b31c0 View commit details
    Browse the repository at this point in the history

  6. fix

    @kianenigma
    kianenigma committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    579da37 View commit details
    Browse the repository at this point in the history

  7. fmt

    @kianenigma
    kianenigma committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    51c1608 View commit details
    Browse the repository at this point in the history

  8. fix migration

    @kianenigma
    kianenigma committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    3779081 View commit details
    Browse the repository at this point in the history

  9. remove event read

    @kianenigma
    kianenigma committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9171a13 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Apply suggestions from code review

    @kianenigma
    kianenigma committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b9ab747 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Update frame/staking/src/lib.rs 

    Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
    @kianenigma @shawntabrizi
    kianenigma and shawntabrizi committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    d4f45e7 View commit details
    Browse the repository at this point in the history

  2. Update frame/nomination-pools/src/lib.rs 

    Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
    @kianenigma @shawntabrizi
    kianenigma and shawntabrizi committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    ca47b05 View commit details
    Browse the repository at this point in the history

  3. Update frame/nomination-pools/src/lib.rs 

    Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
    @kianenigma @shawntabrizi
    kianenigma and shawntabrizi committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    f3e10a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into kiz-fix… 

    …-reward-pools-2
    @kianenigma
    kianenigma committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    463ddfd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'kiz-fix-reward-pools-2' of github.com:paritytech/substr… 

    …ate into kiz-fix-reward-pools-2
    @kianenigma
    kianenigma committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    51873c7 View commit details
    Browse the repository at this point in the history

  3. update

    @kianenigma
    kianenigma committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    c205ac3 View commit details
    Browse the repository at this point in the history

  4. fmt

    @kianenigma
    kianenigma committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    69d1f9c View commit details
    Browse the repository at this point in the history

  5. fmt

    @kianenigma
    kianenigma committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    3efe9f5 View commit details
    Browse the repository at this point in the history

  6. add one last test

    @kianenigma
    kianenigma committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    84a2639 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. fmt

    @kianenigma
    kianenigma committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    e7673f8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:paritytech/substrate into kiz-fix… 

    …-reward-pools-2
    @kianenigma
    kianenigma committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    ed2c225 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. merged

    @kianenigma
    kianenigma committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    de9886d View commit details
    Browse the repository at this point in the history