Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[assets tx payment] configurable default asset #12087

Conversation

dzmitry-lahoda
Copy link

@dzmitry-lahoda dzmitry-lahoda commented Aug 22, 2022

  • Description:

Allows user to configure default tx payment asset. See #12055

  • Is there something left for follow-up PRs?
    Seems benchmarking can be improved, so not sure I have examples how to do multi assets in this repo (so it should be tested in cumulus).

cumulus companion:paritytech/cumulus#1572

  • Labels: You labeled the PR appropriately if you have permissions to do so:
    • A* for PR status (one required)
    • B* for changelog (one required)
    • C* for release notes (exactly one required)
    • D* for various implications/requirements
    • Github project assignment
  • Related Issues: Related #WIP #CU-2nhgxne BYOG pallet version with custom header ComposableFi/composable#1456
  • 2 Reviewers: You asked at least two reviewers to review. If you aren't sure, start with GH suggestions.
  • Style Guide: Your PR adheres to [the style guide]
  • Runtime Version: You bumped the runtime version if there are breaking changes in the runtime. No breaking runtime, only compile time.
  • Docs: You updated any rustdocs which may need to change.
  • Polkadot Companion: Has the PR altered the external API or interfaces used by Polkadot?
    • If so, do you have the corresponding Polkadot PR ready?
    • Optionally: Do you have a corresponding Cumulus PR?

@ggwpez
Copy link
Member

ggwpez commented Aug 27, 2022

cc @shawntabrizi

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

using new storage in tx hook

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

it compiles

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

gods blessed me to compile!

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

tests are built

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

converter usage

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

end to end ed, tests, fixing bench

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

bench compiles

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

clean up

fixed runtime, better names, better tests

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

fixing bench build

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

fixing clippy

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

converte

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

fixing compilation after rebase

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>

fixing compilation after rebase

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
@dzmitry-lahoda
Copy link
Author

seems like other prs also fail with

     Compiling pallet-contracts v4.0.0-dev (/builds/parity/mirrors/substrate/frame/contracts)
  error: generic arguments must come before the first constraint
     --> /builds/parity/mirrors/substrate/frame/uniques/src/lib.rs:114:4
      |
  113 |             Success = Self::AccountId,
      |             ------------------------- constraint
  114 |             Self::Origin,
      |             ^^^^^^^^^^^^
  115 |             Self::CollectionId,
      |             ^^^^^^^^^^^^^^^^^^ generic arguments
      |
  help: move the constraint after the generic arguments
      |
  112 |         type CreateOrigin: EnsureOriginWithArg<Self::Origin, Self::CollectionId, Success = Self::AccountId>;
      |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  warning: ignoring -C extra-filename flag due to -o flag
  warning: `pallet-uniques` (lib) generated 1 warning
  error: could not compile `pallet-uniques` due to previous error; 1 warning emitted
  warning: build failed, waiting for other jobs to finish...

@ggwpez
Copy link
Member

ggwpez commented Sep 22, 2022

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: "git" "push" "--porcelain" "dzmitry-lahoda-forks" "dz/assets-tx-config", kill_on_drop: false }' failed with status Some(128); output: remote: Permission to dzmitry-lahoda-forks/substrate.git denied to paritytech-processbot[bot].
fatal: unable to access 'https://x-access-token:${SECRET}@github.com/dzmitry-lahoda-forks/substrate.git/': The requested URL returned error: 403

@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/parachain-technical-summit-next-steps/51/21

@stale
Copy link

stale bot commented Oct 22, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Oct 22, 2022
@dzmitry-lahoda
Copy link
Author

i will rebase soon to latest master

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Oct 22, 2022
@stale
Copy link

stale bot commented Nov 22, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Nov 22, 2022
@stale stale bot closed this Dec 6, 2022
@dzmitry-lahoda
Copy link
Author

dzmitry-lahoda commented Dec 27, 2022

Fixed merge conflicts and updated to latest master on my branch. Not sure, seems there is no way to reopen PR with stale bot. Only to create new one.

Here is updated branch https://github.com/dzmitry-lahoda-forks/substrate/tree/dz/assets-tx-config (same repo and branch as this PR actually - no changes).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants