Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sp-beefy: align authority id key type with its signature type #13131

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

acatangiu
Copy link
Contributor

Still allows custom message hasher, but ties together the crypto used for private+public keys type and the signature type.

Prerequisite for verifying equivocations in #13121

Still allows custom message hasher, but ties together the crypto
types used for private+public keys and the signature.

Signed-off-by: acatangiu <adrian@parity.io>
@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 12, 2023
@acatangiu acatangiu self-assigned this Jan 12, 2023
@acatangiu acatangiu added the D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. label Jan 12, 2023
@acatangiu
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Rebased

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (code-wise; don't know enough to reason about business logic)

@acatangiu acatangiu merged commit 88be4b6 into paritytech:master Jan 13, 2023
@acatangiu acatangiu deleted the beefy-signature branch January 16, 2023 08:39
@drskalman
Copy link
Contributor

This touches on the issue we were discussing few meetings ago.

It is possible that when we have BLS and ECDAS keys then AuthorityId will not be the same thing as public key. Because the ECDSA key is enough to identify the validator and so we might need to include all BLS public keys arounds. Note that BLS public keys could be as large as 96Bytes and unifying AuthorityId and Public Key could potentially enlarge each beefy messages up to 100KB if they are included in the message as part of AuthorityId.

On the other hand, as it came up in our last meeting, the keystore lacks the ability to associating different type of public keys with each other. So we might need that information to make tell keystore which BLS key of ours to use.

Maybe we should discuss the issue tomorrow in our meeting.

rossbulat pushed a commit that referenced this pull request Feb 3, 2023
Still allows custom message hasher, but ties together the crypto
types used for private+public keys and the signature.

Signed-off-by: acatangiu <adrian@parity.io>
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
…tech#13131)

Still allows custom message hasher, but ties together the crypto
types used for private+public keys and the signature.

Signed-off-by: acatangiu <adrian@parity.io>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…tech#13131)

Still allows custom message hasher, but ties together the crypto
types used for private+public keys and the signature.

Signed-off-by: acatangiu <adrian@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants